Fix constant visibility warnings

Nosto · Mar 21, 2022 · f958685 · f958685
1 parent 1bcb87c
commit f958685
Show file tree

Hide file tree

Showing 55 changed files with 142 additions and 142 deletions.
diff --git a/Api/Data/CustomerInterface.php b/Api/Data/CustomerInterface.php
@@ -40,17 +40,17 @@
 
 interface CustomerInterface
 {
-    const CUSTOMER_ID = 'customer_id';
-    const QUOTE_ID = 'quote_id';
-    const NOSTO_ID = 'nosto_id';
-    const CREATED_AT = 'created_at';
-    const UPDATED_AT = 'updated_at';
-    const RESTORE_CART_HASH = 'restore_cart_hash';
+    public const CUSTOMER_ID = 'customer_id';
+    public const QUOTE_ID = 'quote_id';
+    public const NOSTO_ID = 'nosto_id';
+    public const CREATED_AT = 'created_at';
+    public const UPDATED_AT = 'updated_at';
+    public const RESTORE_CART_HASH = 'restore_cart_hash';
 
     /**
      * @var int The length of the restore cart attribute
      */
-    const NOSTO_TAGGING_RESTORE_CART_ATTRIBUTE_LENGTH = 64;
+    public const NOSTO_TAGGING_RESTORE_CART_ATTRIBUTE_LENGTH = 64;
 
     /**
      * Get customer id

diff --git a/Api/Data/ProductUpdateQueueInterface.php b/Api/Data/ProductUpdateQueueInterface.php
@@ -44,20 +44,20 @@
  */
 interface ProductUpdateQueueInterface
 {
-    const ID = 'id';
-    const CREATED_AT = 'created_at';
-    const STARTED_AT = 'started_at';
-    const COMPLETED_AT = 'completed_at';
-    const STORE_ID = 'store_id';
-    const PRODUCT_IDS = 'product_ids';
-    const PRODUCT_ID_COUNT = 'product_id_count';
-    const ACTION = 'action';
-    const ACTION_VALUE_UPSERT = 'upsert';
-    const ACTION_VALUE_DELETE = 'delete';
-    const STATUS = 'status';
-    const STATUS_VALUE_NEW = 'new';
-    const STATUS_VALUE_PROCESSING = 'processing';
-    const STATUS_VALUE_DONE = 'done';
+    public const ID = 'id';
+    public const CREATED_AT = 'created_at';
+    public const STARTED_AT = 'started_at';
+    public const COMPLETED_AT = 'completed_at';
+    public const STORE_ID = 'store_id';
+    public const PRODUCT_IDS = 'product_ids';
+    public const PRODUCT_ID_COUNT = 'product_id_count';
+    public const ACTION = 'action';
+    public const ACTION_VALUE_UPSERT = 'upsert';
+    public const ACTION_VALUE_DELETE = 'delete';
+    public const STATUS = 'status';
+    public const STATUS_VALUE_NEW = 'new';
+    public const STATUS_VALUE_PROCESSING = 'processing';
+    public const STATUS_VALUE_DONE = 'done';
 
     /**
      * Get row id

diff --git a/Block/Adminhtml/Account/Iframe.php b/Block/Adminhtml/Account/Iframe.php
@@ -59,7 +59,7 @@ class Iframe extends BlockTemplate
 {
     use IframeTrait;
 
-    const IFRAME_VERSION = 1;
+    public const IFRAME_VERSION = 1;
 
     private $nostoHelperAccount;
     private $backendAuthSession;

diff --git a/Block/PageType.php b/Block/PageType.php
@@ -54,7 +54,7 @@ class PageType extends Template
     /**
      * Default type assigned to the page if none is set in the layout xml.
      */
-    const DEFAULT_TYPE = 'unknown';
+    public const DEFAULT_TYPE = 'unknown';
 
     /**
      * Constructor.

diff --git a/Console/Command/NostoAccountConnectCommand.php b/Console/Command/NostoAccountConnectCommand.php
@@ -49,9 +49,9 @@
 
 class NostoAccountConnectCommand extends Command
 {
-    const NOSTO_ACCOUNT_ID = 'account-id';
-    const TOKEN_SUFFIX = '_token';
-    const SCOPE_CODE = 'scope-code';
+    public const NOSTO_ACCOUNT_ID = 'account-id';
+    public const TOKEN_SUFFIX = '_token';
+    public const SCOPE_CODE = 'scope-code';
 
     /**
      * @var NostoHelperAccount

diff --git a/Console/Command/NostoAccountRemoveCommand.php b/Console/Command/NostoAccountRemoveCommand.php
@@ -50,7 +50,7 @@
 
 class NostoAccountRemoveCommand extends Command
 {
-    const SCOPE_CODE = 'scope-code';
+    public const SCOPE_CODE = 'scope-code';
 
     /**
      * @var NostoHelperAccount

diff --git a/Controller/Adminhtml/Account/Connect.php b/Controller/Adminhtml/Account/Connect.php
@@ -44,7 +44,7 @@
 
 class Connect extends Base
 {
-    const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
+    public const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
     private $result;
     private $oauthMetaBuilder;
     private $nostoHelperScope;

diff --git a/Controller/Adminhtml/Account/Create.php b/Controller/Adminhtml/Account/Create.php
@@ -59,7 +59,7 @@
 
 class Create extends Base
 {
-    const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
+    public const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
     private $result;
     private $nostoHelperAccount;
     private $nostoCurrentUserBuilder;

diff --git a/Controller/Adminhtml/Account/Delete.php b/Controller/Adminhtml/Account/Delete.php
@@ -51,7 +51,7 @@
 
 class Delete extends Base
 {
-    const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
+    public const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
     private $result;
     private $nostoHelperAccount;
     private $nostoCurrentUserBuilder;

diff --git a/Controller/Adminhtml/Account/Index.php b/Controller/Adminhtml/Account/Index.php
@@ -47,7 +47,7 @@
 
 class Index extends Base
 {
-    const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
+    public const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
     private $resultPageFactory;
     private $nostoHelperScope;
 

diff --git a/Controller/Adminhtml/Account/Proxy.php b/Controller/Adminhtml/Account/Proxy.php
@@ -42,7 +42,7 @@
 
 class Proxy extends Base
 {
-    const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
+    public const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
     protected $_publicActions = ['proxy']; // @codingStandardsIgnoreLine
     private $backendAuthSession;
 

diff --git a/Controller/Adminhtml/Account/Sync.php b/Controller/Adminhtml/Account/Sync.php
@@ -45,7 +45,7 @@
 
 class Sync extends Base
 {
-    const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
+    public const ADMIN_RESOURCE = 'Nosto_Tagging::system_nosto_account';
     private $result;
     private $nostoHelperAccount;
     private $oauthMetaBuilder;

diff --git a/Controller/Export/Base.php b/Controller/Export/Base.php
@@ -54,9 +54,9 @@
 // https://community.magento.com/t5/Magento-DevBlog/Decomposition-of-Magento-Controllers/ba-p/430883
 abstract class Base extends Action
 {
-    const ID = 'id';
-    const LIMIT = 'limit';
-    const OFFSET = 'offset';
+    public const ID = 'id';
+    public const LIMIT = 'limit';
+    public const OFFSET = 'offset';
 
     private $nostoHelperAccount;
     private $nostoHelperScope;

diff --git a/Controller/Export/Product.php b/Controller/Export/Product.php
@@ -54,7 +54,7 @@
  */
 class Product extends Base
 {
-    const PARAM_PREVIEW = 'preview';
+    public const PARAM_PREVIEW = 'preview';
 
     /** @var CollectionBuilder  */
     private $nostoCollectionBuilder;

diff --git a/Controller/Frontend/Cart.php b/Controller/Frontend/Cart.php
@@ -64,7 +64,7 @@ class Cart extends Action
     /**
      * The name of the hash parameter to look from URL
      */
-    const HASH_PARAM = 'h';
+    public const HASH_PARAM = 'h';
 
     private $context;
     private $moduleManager;

diff --git a/CustomerData/HashedTagging.php b/CustomerData/HashedTagging.php
@@ -42,7 +42,7 @@ abstract class HashedTagging
     /**
      * @var string the algorithm to use for hashing visitor id.
      */
-    const VISITOR_HASH_ALGO = 'sha256';
+    public const VISITOR_HASH_ALGO = 'sha256';
 
     /**
      * Return the checksum for for the customer tagging i.e hashed cookie identifier or HCID for

diff --git a/Exception/ParentProductDisabledException.php b/Exception/ParentProductDisabledException.php
@@ -41,7 +41,7 @@
 
 class ParentProductDisabledException extends NostoException
 {
-    function __construct(int $productId, $code = 0, Throwable $previous = null)
+    public function __construct(int $productId, $code = 0, Throwable $previous = null)
     {
         $message = "Parent product is disabled for SKU with id: " . $productId;
         parent::__construct($message, $code, $previous);

diff --git a/Helper/Account.php b/Helper/Account.php
@@ -64,17 +64,17 @@ class Account extends AbstractHelper
     /**
      * Path to store config nosto account name.
      */
-    const XML_PATH_ACCOUNT = 'nosto_tagging/settings/account';
+    public const XML_PATH_ACCOUNT = 'nosto_tagging/settings/account';
 
     /**
      * Path to store config nosto account tokens.
      */
-    const XML_PATH_TOKENS = 'nosto_tagging/settings/tokens';
+    public const XML_PATH_TOKENS = 'nosto_tagging/settings/tokens';
 
     /**
      * Path to store config store domain.
      */
-    const XML_PATH_DOMAIN = 'nosto_tagging/settings/domain';
+    public const XML_PATH_DOMAIN = 'nosto_tagging/settings/domain';
 
     private $config;
     private $moduleManager;

diff --git a/Helper/Cache.php b/Helper/Cache.php
@@ -50,7 +50,7 @@
  */
 class Cache extends AbstractHelper
 {
-    const CACHE_ID_LAYOUT = 'layout';
+    public const CACHE_ID_LAYOUT = 'layout';
 
     /** @var TypeListInterface $typeList */
     private $typeList;