Skip to content

Merge pull request #361 from Nosto/division-by-zero-when-tax-is-zero #401

Merge pull request #361 from Nosto/division-by-zero-when-tax-is-zero

Merge pull request #361 from Nosto/division-by-zero-when-tax-is-zero #401

Triggered via push January 16, 2025 14:10
Status Success
Total duration 2m 45s
Artifacts 4

action.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

27 warnings
Mess Detect
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v1. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
Copy-Paste Detect
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v1. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
Code Sniffer
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v1. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
Package
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v1. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
Copy-Paste Detect
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Copy-Paste Detect
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Copy-Paste Detect
Skipping prestissimo, as it does not support Composer . Specify composer:v1 in tools to use prestissimo
Mess Detect
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Mess Detect: classes/blocks/NostoDefaultTagging.php#L29
The class NostoDefaultTagging has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
Mess Detect: classes/blocks/NostoRecommendationElement.php#L40
Avoid variables with short names like $id. Configured minimum length is 3.
Mess Detect: classes/helpers/NostoHelperConfig.php#L29
The class NostoHelperConfig has 17 public methods. Consider refactoring NostoHelperConfig to keep number of public methods under 10.
Mess Detect: classes/helpers/NostoHelperConfig.php#L350
The 'getSkuEnabled()' method which returns a boolean should be named 'is...()' or 'has...()'
Mess Detect: classes/helpers/NostoHelperConfig.php#L441
The 'getVariationEnabled()' method which returns a boolean should be named 'is...()' or 'has...()'
Mess Detect: classes/helpers/NostoHelperConfig.php#L459
The 'getVariationTaxRuleEnabled()' method which returns a boolean should be named 'is...()' or 'has...()'
Mess Detect: classes/helpers/NostoHelperContext.php#L29
The class NostoHelperContext has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
Mess Detect: classes/helpers/NostoHelperContext.php#L32
Avoid excessively long variable names like $backupShopContextStack. Keep variable name length under 20.
Mess Detect: classes/helpers/NostoHelperController.php#L73
The method resolveObject() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Mess Detect: classes/helpers/NostoHelperController.php#L79
Avoid variables with short names like $id. Configured minimum length is 3.
Mess Detect
Skipping prestissimo, as it does not support Composer . Specify composer:v1 in tools to use prestissimo
Mess Detect
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Package
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Package
Skipping prestissimo, as it does not support Composer . Specify composer:v1 in tools to use prestissimo
Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Sniffer
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Code Sniffer
Skipping prestissimo, as it does not support Composer . Specify composer:v1 in tools to use prestissimo
Code Sniffer
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Artifacts

Produced during runtime
Name Size
4.4.1-Nosto.-.Personalization.for.PrestaShop
1.27 MB
phdpcpd-xml-result
188 Bytes
phpcs-xml-result
207 Bytes
phpmd-xml-result
3.32 KB