Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-745: use reportAddToCart and support string slotId parameter #363

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

manikandan-ravikumar
Copy link
Contributor

Description

Aligns addSkuToCart signature with other platforms (Shopify/BigCommerce)

Related Issue

https://nostosolutions.atlassian.net/browse/CFE-745

Motivation and Context

https://nostosolutions.atlassian.net/wiki/spaces/CFE/pages/11329273857/Nosto+JS+API
https://nostosolutions.atlassian.net/wiki/spaces/CFE/pages/11336613892/Signature+Alignment

How Has This Been Tested?

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non-existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

Copy link
Member

@supercid supercid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@supercid supercid merged commit 2e0de05 into develop Jan 17, 2025
6 checks passed
@supercid supercid deleted the CFE-745-align-nostojs-functions branch January 17, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants