-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Sacks page in pv #891
Conversation
src/main/java/io/github/moulberry/notenoughupdates/core/util/StringUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
src/main/java/io/github/moulberry/notenoughupdates/profileviewer/SacksPage.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to move the "Back" button within sack to the bottom left or right and then moving the arrows down a bit.
Another thing is maybe changing the amount of items to light gray instead of green? Not sure if it will look good, tho.
The last thing i saw is that maybe you should add a small note in the sack lore that you can click on them to see a more detailed view of the sack.
Did all of these, light grey does look good |
Tested out the new changes and they look nice. I have 3 suggestions you could think about if you want to do them (i have no idea if they will look good.
|
From testing did not crash with missing repo file
Shows an overview of all sacks along with the breakdown of individual sacks
Rune sack works differently where it only shows the runes in the player's sack API whereas everything else shows the whole sack regardless of how many items you have in the sack.
Is part of the inventories page