Skip to content

Make the paddings of list blocks aligned with Notion style #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make the paddings of list blocks aligned with Notion style #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/react-notion-x/src/block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,14 +443,14 @@ export const Block: React.FC<BlockProps> = (props) => {

if (block.content) {
output = (
<>
{block.properties && (
<li>
<li>
<span>
{block.properties && (
<Text value={block.properties.title} block={block} />
</li>
)}
)}
</span>
{wrapList(children)}
</>
</li>
)
} else {
output = block.properties ? (
Expand Down
33 changes: 22 additions & 11 deletions packages/react-notion-x/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,17 +766,16 @@ svg.notion-page-icon {
margin: 0;
margin-block-start: 0.6em;
margin-block-end: 0.6em;
padding-inline-start: 28px;
}

.notion-list-disc {
list-style-type: disc;
padding-inline-start: 1.7em;
margin-top: 0;
margin-bottom: 0;
}
.notion-list-numbered {
list-style-type: decimal;
padding-inline-start: 1.6em;
margin-top: 0;
margin-bottom: 0;
}
Expand All @@ -790,10 +789,19 @@ svg.notion-page-icon {
}

.notion-list li {
padding: 6px 0;
padding: 6px 2px;
white-space: pre-wrap;
}

.notion-list li > .notion-list {
padding-inline-start: 26px;
}

.notion-list li > .notion-list > :not(li) {
margin-left: -28px;
width: calc(100% + 28px);
}

.notion-asset-wrapper {
margin: 0.5rem 0;
max-width: 100vw;
Expand Down Expand Up @@ -1128,15 +1136,15 @@ svg.notion-page-icon {

.notion-toggle {
width: 100%;
padding: 3px 2px;
padding: 3px 2px 3px 28px;
}
.notion-toggle > summary {
list-style-position: outside;
padding-left: 2px;
padding-right: 2px;
cursor: pointer;
outline: none;
}
.notion-toggle > div {
margin-left: 1.1em;
}

.notion-collection {
align-self: center;
Expand Down Expand Up @@ -1398,8 +1406,9 @@ svg.notion-page-icon {
}

.notion-property-checkbox {
width: 16px;
height: 16px;
width: 24px;
display: flex;
justify-content: center;
}

.notion-property-checkbox-checked {
Expand Down Expand Up @@ -1769,7 +1778,7 @@ svg.notion-page-icon {
}

.notion-to-do-children {
padding-left: 1.5em;
padding-left: 28px;
}

.notion-to-do-checked .notion-to-do-item {
Expand All @@ -1778,12 +1787,14 @@ svg.notion-page-icon {
}

.notion-to-do-body {
padding-left: 2px;
padding-right: 2px;
white-space: pre-wrap;
word-break: break-word;
}

.notion-to-do-item .notion-property-checkbox {
margin-right: 8px;
margin-right: 2px;
}

.notion-google-drive {
Expand Down