Skip to content

Fix private file signed url generation #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix private file signed url generation #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c9c1ab
fix: Update how private file urls are detected
worgho2 Dec 14, 2024
29111e5
fix: Update react-pdf worker cdn src
worgho2 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions packages/notion-client/src/notion-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,17 +237,17 @@ export class NotionAPI {
// console.log(block, source)

if (source) {
if (!source.includes('secure.notion-static.com')) {
return []
if (source.includes('secure.notion-static.com') || source.includes('prod-files-secure')) {
return {
permissionRecord: {
table: 'block',
id: block.id
},
url: source
};
}

return {
permissionRecord: {
table: 'block',
id: block.id
},
url: source
}
return []
}
}

Expand Down
2 changes: 1 addition & 1 deletion packages/react-notion-x/src/third-party/pdf.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react'
import { Document, Page, pdfjs } from 'react-pdf'

// ensure pdfjs can find its worker script regardless of how react-notion-x is bundled
pdfjs.GlobalWorkerOptions.workerSrc = `//unpkg.com/pdfjs-dist@${pdfjs.version}/legacy/build/pdf.worker.min.js`
pdfjs.GlobalWorkerOptions.workerSrc = `//unpkg.com/pdfjs-dist@${pdfjs.version}/legacy/build/pdf.worker.min.mjs`

export function Pdf({ file, ...rest }: { file: string }) {
const [numPages, setNumPages] = React.useState<number>(0)
Expand Down
Loading