Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing tests for NovaVault interfaces #15

Merged
merged 5 commits into from
May 25, 2024
Merged

Writing tests for NovaVault interfaces #15

merged 5 commits into from
May 25, 2024

Conversation

Imad-Allal
Copy link
Collaborator

The transferFrom in the deposit function of the NovaAdapterVelo contract is failing:

  ├─ [11339] NovaVault::deposit(0x0b2C639c533813f4Aa9D7837CAf62653d097Ff85, 100000000 [1e8])
    │   ├─ [5265] NovaAdapterVelo::deposit(100000000 [1e8]) [delegatecall]
    │   │   ├─ [0] 0x0000000000000000000000000000000000000000::transferFrom(0x000000000000000000000000000000000000ABcD, NovaVault: [0x2e234DAe75C793f67A35089C9d99245E1C58470b], 100000000 [1e8])
    │   │   │   └─ ← [Stop] 
    │   │   └─ ← [Revert] EvmError: Revert
    │   └─ ← [Return] false, 0x
    └─ ← [Revert] panic: assertion failed (0x01)

@Imad-Allal
Writing tests for NovaVault interfaces

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
95e7670
lakonema2000
lakonema2000 reviewed May 22, 2024
View reviewed changes
lakonema2000
lakonema2000 reviewed May 23, 2024
View reviewed changes
@Imad-Allal Imad-Allal merged commit 8249721 into main May 25, 2024
1 check passed
@Imad-Allal Imad-Allal deleted the test/test-nova-interfaces branch May 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lakonema2000 lakonema2000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Imad-Allal @lakonema2000