Account for no-op restore when deciding to update the info bar #6245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Jan 31, 2025
martinrrm
previously approved these changes
Feb 4, 2025
nkolev92
force-pushed
the
dev-nkolev92-smartVulnerabilityInfobar
branch
from
9eb9864 to
c561fad
Compare
jeffkl
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13318
Description
Account for no-op restore when deciding to update the info bar.
If we perform a full no-op for restore, it usually means that we have not performed an audit check, which means we won't have updates for the info-bar.
PR Checklist
Added testsUnfortunately this is incredibly difficult to test in an automated way. Our vendors will cover this.Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.