Fix auto referenced calculation - remove redundant work #6346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
Nigusu-Allehu
approved these changes
Mar 25, 2025
jgonz120
reviewed
Mar 25, 2025
jgonz120
approved these changes
Mar 25, 2025
martinrrm
approved these changes
Mar 27, 2025
zivkan
approved these changes
Mar 27, 2025
jebriede
approved these changes
Mar 28, 2025
|
Yes, I did validate it. I fixed the PR checklist section originally, but not the body |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3205
Description
I think this should address the unneeded looping over the packages.
The bug calls out 3 scenarios for the PackageItemViewModel construction.
One in https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.PackageManagement.UI/PackageItemLoader.cs#L344, which is what I'm fixing here by calculating the AutoReferenced metadata at the same spot the exactly specified version is calculated.
https://github.com/NuGet/NuGet.Client/blob/dev/src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/InfiniteScrollList.xaml.cs#L615 is called after the
PackageCollection.FromPackageReferenceswhich handles the metadata construction correctly.cc @jebriede
PR Checklist
Added testsNo automated tests in this space. I tested manually.Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.