-
Notifications
You must be signed in to change notification settings - Fork 235
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge remote-tracking branch 'refs/remotes/origin/master' into release
- Loading branch information
Showing
7 changed files
with
56 additions
and
49 deletions.
There are no files selected for viewing
44 changes: 44 additions & 0 deletions
44
src/NuGet.Server/DataServices/NormalizeVersionInterceptor.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
||
using System.Linq.Expressions; | ||
using System.Reflection; | ||
|
||
namespace NuGet.Server.DataServices | ||
{ | ||
public class NormalizeVersionInterceptor : ExpressionVisitor | ||
{ | ||
private static readonly MemberInfo _versionMember = typeof(ODataPackage).GetProperty("Version"); | ||
private static readonly MemberInfo _normalizedVersionMember = typeof(ODataPackage).GetProperty("NormalizedVersion"); | ||
|
||
protected override Expression VisitBinary(BinaryExpression node) | ||
{ | ||
// Change equality comparisons on Version to normalized comparisons on NormalizedVersion | ||
if (node.NodeType == ExpressionType.Equal) | ||
{ | ||
// Figure out which side is the target | ||
ConstantExpression constSide = (node.Left as ConstantExpression) ?? (node.Right as ConstantExpression); | ||
if (constSide != null && constSide.Type == typeof(string)) | ||
{ | ||
MemberExpression memberSide = (node.Right as MemberExpression) ?? (node.Left as MemberExpression); | ||
if (memberSide != null && memberSide.Member == _versionMember) | ||
{ | ||
// We have a "Package.Version == <constant>" expression! | ||
|
||
// Transform the constant version into a normalized version | ||
SemanticVersion semanticVersion; | ||
if (SemanticVersion.TryParse((string) constSide.Value, out semanticVersion)) | ||
{ | ||
// Create a new expression that checks the new constant against NormalizedVersion instead | ||
return Expression.MakeBinary( | ||
ExpressionType.Equal, | ||
left: Expression.Constant(semanticVersion.ToNormalizedString()), | ||
right: Expression.MakeMemberAccess(memberSide.Expression, _normalizedVersionMember)); | ||
} | ||
} | ||
} | ||
} | ||
return node; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 0 additions & 44 deletions
44
src/NuGet.Server/DataServices/PackageIdComparisonVisitor.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters