Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongoose npm package to v5.5.5 #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhuang612
Copy link

I reviewed the test errors that were happening

     TypeError: Cannot read property '$handleCallbackError' of undefined

with this being the error.

I found that some of the tests had extra .chains that were including stuff such as

.chain('limit')

But they weren't being called with params
as talked about on this SO question
https://stackoverflow.com/questions/44188675/unit-testing-mongoose-model-callback-with-sinon

I removed those extra params and got a new error.
Through research I figured out how to return the results of the tests to be errors and updated the code.
I then ran npm test and confirmed the errors were gone.

Please let me know if anything else needs to be resolved.

Thanks

@dhuang612
Copy link
Author

dhuang612 commented Jan 3, 2020

I can bump the mongoose package up to v 5.8 so that the bot stops trying to merge new commits
@YasharF

updated package dependency and resolved test errors
@dhuang612 dhuang612 force-pushed the update-mongoose-package-dependency branch from 14d4071 to ae70f99 Compare January 15, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants