added a check for sinon.sandbox for sinon v8 compatibility
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved `sinon.sandbox.create` and bumped the peer dependency to `5 - 8`
|
hey guys, i've tried to keep the compatibility with older versions of |
mir4ef
changed the title
sinon.sandbox for sinon v8 compatabilitysinon.sandbox for sinon v8 compatibility
|
Can't wait till this is merged! |
|
hi guys, just following up to see if you had a chance to review the PR? |
|
sinon v9 is out now, and this PR is all I need to do upgrade to sinon v9 |
|
@gaguirre Please merge this. |
|
@gaguirre Please merge this so we can use sinon-mongoose |
|
Same as the others...please merge this PR |
|
Any Update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58 added a check for
sinon.sandboxforsinonv8 compatability and bumped the peer dependency to5 - 8