Make generators configurable in map JSON files#51
Merged
Gegy merged 3 commits intoNucleoidMC:1.17from Sep 26, 2021
Genau6502:1.17
Merged
Make generators configurable in map JSON files#51Gegy merged 3 commits intoNucleoidMC:1.17from Genau6502:1.17
Gegy merged 3 commits intoNucleoidMC:1.17from
Genau6502:1.17
Conversation
Gegy
reviewed
Sep 26, 2021
Member
Gegy
left a comment
There was a problem hiding this comment.
Ooh yay- thank you for this PR! This is a very much needed change, very excited to see what we can do with this new configuration in terms of balancing different maps!
src/main/java/xyz/nucleoid/bedwars/game/active/ItemGeneratorPool.java
Outdated
Show resolved
Hide resolved
src/main/java/xyz/nucleoid/bedwars/game/active/ItemGeneratorPools.java
Outdated
Show resolved
Hide resolved
src/main/java/xyz/nucleoid/bedwars/game/config/GeneratorConfig.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a generator field to all map config files. This allows fine-tuning of spawn chances and speeds of items in all generators, allowing for per-map balancing. This approach means that the overall increasing of rates in #41 is not needed - small maps can be tweaked to have slower generators and vice versa
Default generator speed as of before this PR: