Add ten FOCI'24 issue 2 papers, two PETS'24 papers, and support accent characters in cite names. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfw-report
added a commit
to gfw-report/bibtex
that referenced
this pull request
Jul 17, 2024
This commit enables the support of accent characters in the bib key:
> @inproceedings{Müller2024a,
Without this commit, the accent characters will cause the parse error, e.g.:
> Cannot parse valid bibtex file example/biblatex-examples.bib: parse failed at 1676:17: syntax error
One real-world use case is available at: NullHypothesis/censorbib#51.
I opened the pull request: nickng/bibtex#25 |
* PETS publication page: https://www.petsymposium.org/foci/2024/ * FOCI program: https://foci.community/foci24.html#2024-summer-program * Net4People post: net4people/bbs#376 I do not include the three papers in Session III: Privacy Enhancing Technologies, as they are out of scope of Internet censorship.
A new commit introduces a cite name that contains an accent character:
@inproceedings{Müller2024a,
It will cause the bibtex parser to fail with the following two errors:
failed to extract cite name of: @inproceedings{Müller2024a,
and
parse failed at 55:17: syntax error: unexpected $end, expecting tCOMM
The second error is an upstream limitation,
which I will try to get it merged to the upstream: https://github.com/nickng/bibtex.
This is to support accent characters in bib key: https://github.com/nickng/bibtex/releases/tag/v1.4.0
Selected from: net4people/bbs#376.
NullHypothesis
requested changes
Jul 20, 2024
|
I have now removed Thank you so much for your review, @NullHypothesis ! |
|
I added two PETS'24 papers in this PR. |
gfw-report
changed the title
NullHypothesis
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains two major components:
I do not include the three papers in Session III: Privacy Enhancing Technologies, as they are out of scope of Internet censorship.
A new commit introduces a cite name that contains an accent character:
It will cause the bibtex parser to fail with the following two errors:
and
We have both errors fixed in this commit. The second error is an upstream limitation, which I will try to get it merged to the upstream: https://github.com/nickng/bibtex.