Fix subsidence forcing #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence forcing - also includes average profile writer and plane writer"" This reverts commit 81196e3.
Signed-off-by: Madi Rosevear <madelaine.gamblerosevear@utas.edu.au>
glwagner
reviewed
Jun 30, 2025
navidcy
changed the title
navidcy
reviewed
Sep 6, 2025
Signed-off-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Signed-off-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're missing a step in the subsidence forcing (highlighted below) - we create fields u_avg = Field{Nothing, Nothing, Center}(grid) but never use the model fields to populate them.
I'd be grateful for help with this - I'm a little confused about your approach @glwagner of supplying u_avg (etc) to Forcing as a parameter.