-
Notifications
You must be signed in to change notification settings - Fork 61
feat(tests): add JSON Schema test coverage #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): add JSON Schema test coverage #286
Conversation
af5f4af to
7263e27
Compare
|
rebased on v1.0.0-dev to resolve conflicts. |
ralfhandl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeremyfiel Why is the specification markdown source changed by this PR?
|
Markdown lint was added and the rebase onto v1.0.0-dev included some recent updates by Frank I didn't change any wording on it |
|
I would separate these changes into two separate pull requests:
|
7263e27 to
45d61f5
Compare
|
fc6b037 to
8b2dc94
Compare
jeremyfiel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mistakenly removed the original validate-markdown.yaml with mdv checks.
7046008 to
53c8b4f
Compare
|
opps. somehow the validate-markdown.yaml was deleted again. added it back. it will be replaced and updated by #291 pr after that one is merged. |
frankkilcommins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jeremyfiel - i'm requested changed on the examples to ensure they are valid (which is being fixed for the examples directly in #260 )
Can you also take a look at the merge conflicts?
53c8b4f to
8c0204f
Compare
|
tbh, i'm not sure why this is a conflict. the file currently exists on |
* remove json version of schema * add package-lock.json * update test case examples to use proper ABNF syntax reused from OAS/Overlay projects
8c0204f to
61685fe
Compare
|
interesting. adding the file back removes the conflict. I can create a separate pr to remove the file after this is merged.. lmk if that works |
|
taking inspiration from @ralfhandl to update the schema test coverage threshold to 100% like this will not work for this repo because we are not testing the JSON Schema 2020-12 keywords used in |
This PR adds schema test coverage for the JSON Schema,
this is based on the work in the OAS and Overlay projects by @MikeRalphson and @ralfhandl
The schema tests do not cover JSON Schema 2020-12 keywords as defined by the
inputskeyword. All Arazzo specific keywords are covered by the tests.I've also included markdownlint-cli to clean up the spec file.