Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] scripts/update-schema-id #3790

Closed

Conversation

TakahikoKawasaki
Copy link

This script updates the schema IDs in the following YAML files:

  • schemas/v{major}.{minor}/schema.yaml
  • schemas/v{major}.{minor}/schema-base.yaml

and generates the following JSON files from the updated YAML files:

  • schemas/v{major}.{minor}/schema.json
  • schemas/v{major}.{minor}/schema-base.json

This script updates the schema IDs in the following YAML files:

  schemas/v{major}.{minor}/schema.yaml
  schemas/v{major}.{minor}/schema-base.yaml

and generates the following JSON files from the updated YAML files:

  schemas/v{major}.{minor}/schema.json
  schemas/v{major}.{minor}/schema-base.json
@TakahikoKawasaki TakahikoKawasaki requested review from a team as code owners May 8, 2024 10:33
def error_exit(message)
$stderr.puts message
exit false
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built-in abort (method of Kernel) does the same as this error_exit method

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notEthan Thank you! I have replaced error_exit with abort.

@lornajane
Copy link
Contributor

Thanks for getting us started with this change. We don't currently have any Ruby code in our repository, and it's not a skill present in our current maintainer cohort either. Could we discuss what this script does, and whether we can use a tech stack that is already in use?

@TakahikoKawasaki
Copy link
Author

Okay. A shell script version is here --> PR #3814

@handrews
Copy link
Member

Replaced by #3814

@handrews handrews closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants