Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upheno.md #2648

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Update upheno.md #2648

merged 3 commits into from
Nov 6, 2024

Conversation

jamesamcl
Copy link
Contributor

nlharris
nlharris approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@nlharris nlharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (thanks for fixing a few typos and adding a publication, as well as switching the contact person).

As a best practice, I recommend putting something in the commit message about what you're changing.

@deepakunni3 deepakunni3 self-requested a review November 6, 2024 10:39
deepakunni3
deepakunni3 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@deepakunni3 deepakunni3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesamcl I took the liberty of quoting the title for publication on line 37: jamesamcl@752a591#diff-c0c6a42b3c26feecc1bedcf274e6ff30b504a11b456c8676ae9fb7b5bca5f830L37

The lack of quotes was causing issues with the YAML parser.

@deepakunni3 deepakunni3 merged commit 55a0619 into OBOFoundry:master Nov 6, 2024
3 checks passed
@matentzn
Copy link
Contributor

matentzn commented Nov 6, 2024

Awesome thanks @jamesamcl and @deepakunni3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@deepakunni3 deepakunni3 deepakunni3 approved these changes

@nlharris nlharris nlharris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesamcl @matentzn @nlharris @deepakunni3