Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_statement_import_online_gocardless: prefer valueDate over bookingDate #689

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Rad0van
Copy link

@Rad0van Rad0van commented May 1, 2024

This fixes behavior when there are debit card transactions with bookingDate behind the actual valueDate. In current situation this leads to a situation where these are later discarded in here:

if date < statement_date_since:
if "balance_start" in statement_values:
statement_values["balance_start"] = Decimal(
statement_values["balance_start"]
) + Decimal(line_values["amount"])
lines_before_since += 1
continue

Here's a screenshot of such situation.
gocardless_issue

@pedrobaeza pedrobaeza added this to the 16.0 milestone May 2, 2024
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@Rad0van
Copy link
Author

Rad0van commented Sep 1, 2024

Aby comments? GitHub is telling me it's going to be closed due to inactivity..m

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 8, 2024
@droidosergioh
Copy link

Hello,

Any news about it? This fixes an error we are facing.

Kindest Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants