Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] contract: Report correction #1178

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[16.0][IMP] contract: Report correction #1178

merged 1 commit into from
Jan 14, 2025

Conversation

arielbarreiros96
Copy link
Contributor

Report correction. preventing unintended styling when using external_layout_boxed

Issue #1176

@arielbarreiros96 arielbarreiros96 mentioned this pull request Jan 10, 2025
Closed
@rousseldenis
Copy link
Contributor

@arielbarreiros96 Could you make contract module name appear in your commit message:

image

Thanks

@arielbarreiros96
Copy link
Contributor Author

arielbarreiros96 commented Jan 10, 2025 •
edited
Loading

@arielbarreiros96 Could you make contract module name appear in your commit message:

image

Thanks

Sure thing, I'll also remove the 16.0 from the commit, since it it should not be there but in the PR name, thanks 👌🙂

AinohaBH
AinohaBH approved these changes Jan 10, 2025
View reviewed changes
Copy link

@AinohaBH AinohaBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional: LGTM

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 13, 2025
@pedrobaeza pedrobaeza changed the title [16.0][IMP] Report correction [16.0][IMP] contract: Report correction Jan 13, 2025
@pedrobaeza
Copy link
Member

/ocabot merge patch

@Christian-RB
Copy link

It seems like the bot was at nap time, can you try again @pedrobaeza?

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1178-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at aae77df. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit c1adcae into OCA:16.0 Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AinohaBH AinohaBH AinohaBH approved these changes

@adasatorres adasatorres adasatorres approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@arielbarreiros96 @rousseldenis @pedrobaeza @Christian-RB @OCA-git-bot @carlosdauden @adasatorres @AinohaBH