[18.0][FIX] contract line successor: use parent.is_auto_renew to avoid EvalError in column_invisible #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sbejaoui, |
Anxo82
changed the title
Anxo82
force-pushed
the
18.0-FIX-contract_line_successor
branch
2 times, most recently
from
67454d0 to
f8c6a94
Compare
Anxo82
changed the title
Anxo82
force-pushed
the
18.0-FIX-contract_line_successor
branch
from
f8c6a94 to
c657971
Compare
Anxo82
force-pushed
the
18.0-FIX-contract_line_successor
branch
from
c657971 to
e03d038
Compare
Jaimermaccione
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
@Anxo82 I’ve tested the described case and the error no longer occurs. I’d say this works fine now from a functional point of view. LGTM!
|
This PR has the |
|
@pedrobaeza Could we merge this FIX? THX! 🙏 |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 0efa8f0. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HaraldPanten
[T-8579]
When creating a new contract template and selecting "supplier" as the contract_type, show an EvalError "Can not evaluate python expression: (bool(parent.contract_type == 'purchase' and not is_auto_renew))"
The fix replaces
is_auto_renewwithparent.is_auto_renewto ensure the expression is evaluated correctly in the context of the parent form. To make this work, the is_auto_renew field was added as a computed Boolean field on the contract.template model.