[17.0][FIX] account_credit_control: correctly update control lines status #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root tag for the message could be a span in certain cases, so these are excluded from the check. The email_from is defined in the template, so it should be set on the company to be able to send it.
pedrobaeza
reviewed
Jul 10, 2025
| for comm in self: | ||
| comm.message_mail_with_source( | ||
| # in mass_mail mode, the subtype is dropped, which is used by the | ||
| # postprocessing that marks control lines as sent.lines |
Member
There was a problem hiding this comment.
Suggested change
| # postprocessing that marks control lines as sent.lines | |
| # postprocessing that marks control lines as sent lines |
| ) | ||
| comm.credit_control_line_ids.filtered( | ||
| lambda line: line.state == "queued" | ||
| ).state = "sent" |
Member
There was a problem hiding this comment.
Please relaunch it for merging the patch, as now it's not possible to reopen the PR.
yvaucher
changed the title
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.