-
-
Notifications
You must be signed in to change notification settings - Fork 232
[18.0][ADD] account_credit_control_aggregate_level - Aggregate multiple levels in credit lines to make single communications #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
len-foss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ADD] is supposed to be for new modules. Here there's a small [REF] refactoring of the module, and mostly [IMP] improvements to it. Which I'm not sure should go into it and not into another module. The rationale for that is that this module is already quite buggy, so I would think keeping it as lightweight as possible would be best.
195a0ab to
b47175e
Compare
|
@len-foss Thanks for your input, I'll modify this PR to create a module |
|
@yvaucher that's great! There's another that you're unlikely to catch with simple test: |
3b739fb to
926387a
Compare
Add the possibility to mark a policy so that processing a line generated by this policy will also process lower level lines for the same partner (and policy). Also add a filter for credit control line tree view in order to only display highest level lines for each partner and policy.
Revert to the SQL query and extend it with auto_process, ignoring level to group more lines. Revert the yielding method to simply order lines on search to get the highest level in an auto_process group.
8ec67c9 to
12ffa8f
Compare
This is an extraction of the feature added in account_credit_control
12ffa8f to
a9017b1
Compare
Forward port of #22
In case of recurring invoicing you might have multiple lines with different levels, however you don't want to multiply the communications to the creditor.
This adds the possibility to communicate only the highest due and attach the lower levels to it to not de-multiply the communications.
Compared to
Apply max policy level, the aim is to keep distinct level values on credit lines and not create them at the same level."Auto Process Lower levels" means that you have to care only about the highest level and that other lines for the same partner, policy will be communicated as well.