-
-
Notifications
You must be signed in to change notification settings - Fork 232
[18.0][FIX] partner_risk_insurance: error duplicate contact #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][FIX] partner_risk_insurance: error duplicate contact #538
Conversation
|
Hi @yajo, @sergio-teruel, @Daniel-CA, @Shide, @Tardo, @rafaelbn, @omar7r, |
chienandalu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you should apply it to the other fields, as they wouldn't be relevant for a new company. For example, the risk_insurance_code.
cda631b to
da58e64
Compare
|
flotho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Thanks for this fix, LGTM
|
@Andrii9090 add copy=False to |
When attempting to duplicate a contact (res.partner model), users with limited invoice permissions receive a permission error. The duplication is not completed because the system attempts to read the insurance_credit_limit and risk_insurance_coverage_percent fields. MT-13337
da58e64 to
a63d6b0
Compare
Shide
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm
chienandalu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
yajo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ad32e50. Thanks a lot for contributing to OCA. ❤️ |
When attempting to duplicate a contact (
res.partnermodel), users with limited invoice permissions receive a permission error. The duplication is not completed because the system attempts to read theinsurance_credit_limitandrisk_insurance_coverage_percentfields.And I add
copy=Falsefor risk_insurance_requested, risk_insurance_grant_date, risk_insurance_code, risk_insurance_code_2.With this small fix we can duplicate a contact

MT-13337
@moduon