-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] crm_claim: Migration to 17.0 #594
Open
BernatObrador
wants to merge
39
commits into
OCA:17.0
Choose a base branch
from
APSL:17.0-mig-crm_claim
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Please check CI |
BernatObrador
force-pushed
the
17.0-mig-crm_claim
branch
2 times, most recently
from
August 8, 2024 11:03
1aa8a1c
to
901ec7f
Compare
mpascuall
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BernatObrador
force-pushed
the
17.0-mig-crm_claim
branch
from
August 8, 2024 12:32
901ec7f
to
b638ae0
Compare
Include record rule for multi-company.
BernatObrador
force-pushed
the
17.0-mig-crm_claim
branch
2 times, most recently
from
August 8, 2024 12:40
1f70569
to
0022673
Compare
Squash administrive commits please @BernatObrador |
The Claim form's statusbar is intended to be clickable, but Odoo 13 is apparently no longer compatible with `clickable="True"`. Instead, either `clickable="1"` or `options="{'clickable': 1}"` must be used. Odoo core code uses the latter, so the Claim form has been updated to match core convention.
Currently translated at 100.0% (144 of 144 strings) Translation: crm-14.0/crm-14.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_claim/de/
We didn't have activities back in v8 but the fields `action_next` and `date_deadline` in the models to be set from the views. In the later migration to v11 those view fields were adapted to the proper similar ones in activities. But that's useless, as activities have their own UI ready to be used from any model with the mixin. TT38822
Currently translated at 100.0% (147 of 147 strings) Translation: crm-15.0/crm-15.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/es/
Currently translated at 100.0% (147 of 147 strings) Translation: crm-15.0/crm-15.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/ca/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/it/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 100.0% (143 of 143 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 91.5% (130 of 142 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/fr_FR/
It's setting a context when creating records for the default team_id and it's not necessary, it's redundant because the team_id field already has a default that defines it. This code is not necessary. TT49102
…to claim form view TT46565
Currently translated at 16.1% (23 of 142 strings) Translation: crm-16.0/crm-16.0-crm_claim Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/pt_BR/
BernatObrador
force-pushed
the
17.0-mig-crm_claim
branch
from
August 9, 2024 06:15
0022673
to
629414f
Compare
peluko00
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in runboat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 17.0
cc https://github.com/APSL 159308
@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review