Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] crm_claim: Migration to 17.0 #594

Open
wants to merge 39 commits into
base: 17.0
Choose a base branch
from

Conversation

BernatObrador
Copy link

@BernatObrador BernatObrador commented Aug 8, 2024

Module migrated to version 17.0

cc https://github.com/APSL 159308

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

@BernatObrador BernatObrador mentioned this pull request Aug 8, 2024
19 tasks
@pedrobaeza pedrobaeza mentioned this pull request Aug 8, 2024
@pedrobaeza
Copy link
Member

Please check CI

@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_claim branch 2 times, most recently from 1aa8a1c to 901ec7f Compare August 8, 2024 11:03
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BernatObrador BernatObrador force-pushed the 17.0-mig-crm_claim branch 2 times, most recently from 1f70569 to 0022673 Compare August 8, 2024 12:40
@peluko00
Copy link

peluko00 commented Aug 8, 2024

Squash administrive commits please @BernatObrador

flachica and others added 8 commits August 9, 2024 08:14
The Claim form's statusbar is intended to be clickable, but Odoo 13 is
apparently no longer compatible with `clickable="True"`. Instead, either
`clickable="1"` or `options="{'clickable': 1}"` must be used. Odoo core
code uses the latter, so the Claim form has been updated to match core
convention.
Currently translated at 100.0% (144 of 144 strings)

Translation: crm-14.0/crm-14.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_claim/de/
bizzappdev and others added 20 commits August 9, 2024 08:14
We didn't have activities back in v8 but the fields `action_next` and
`date_deadline` in the models to be set from the views. In the later migration
to v11 those view fields were adapted to the proper similar ones in activities.
But that's useless, as activities have their own UI ready to be used from any
model with the mixin.

TT38822
Currently translated at 100.0% (147 of 147 strings)

Translation: crm-15.0/crm-15.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/es/
Currently translated at 100.0% (147 of 147 strings)

Translation: crm-15.0/crm-15.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-15-0/crm-15-0-crm_claim/ca/
Currently translated at 100.0% (143 of 143 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/it/
Currently translated at 100.0% (143 of 143 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 100.0% (143 of 143 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/es/
Currently translated at 91.5% (130 of 142 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/fr_FR/
It's setting a context when creating records for the default team_id and it's not necessary, it's redundant because the team_id field already has a default that defines it. This code is not necessary.

TT49102
Currently translated at 16.1% (23 of 142 strings)

Translation: crm-16.0/crm-16.0-crm_claim
Translate-URL: https://translation.odoo-community.org/projects/crm-16-0/crm-16-0-crm_claim/pt_BR/
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.