[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019

FernandoRomera · 2024-08-06T08:39:21Z

No description provided.

…a XML Associate `queue job channels` with delayable methods via XML and add migration script fixup with edi_voxel_account_invoice_oca

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-15.0/edi-15.0-edi_voxel_account_invoice_oca Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_voxel_account_invoice_oca/

- Include context keys for avoiding mail operations overhead.

Currently translated at 100.0% (32 of 32 strings) Translation: edi-15.0/edi-15.0-edi_voxel_account_invoice_oca Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_voxel_account_invoice_oca/es/

Inheriting post instead of _post makes that certain roots followed to post invoices didn't trigger the Voxel sending, which is incorrect. Let's inherit the low level method then. TT49512

FernandoRomera · 2024-08-06T09:22:36Z

@pedrobaeza
This is the first time this has happened to me, I have to downgrade this PR to Beta?.

Run manifestoo -d . check-dev-status --default-dev-status=Beta
edi_voxel_account_invoice_oca (Production/Stable) depends on stock_picking_invoice_link (Beta)
Error: Process completed with exit code 1.

pedrobaeza · 2024-08-06T10:26:03Z

I think you should promote instead stock_picking_invoice_link to Mature. The problem is that this check was not done in previous versions, and the default one for all the modules is Beta.

FernandoRomera · 2024-08-06T11:11:15Z

Depend:

[17.0][FIX] stock_picking_invoice_link: development status stock-logistics-workflow#1667

FernandoRomera · 2024-08-06T11:19:13Z

@pedrobaeza
Done, can you help me to merge it OCA/stock-logistics-workflow#1667?

FernandoRomera · 2024-08-06T12:44:02Z

@pedrobaeza
Thank you for all your help.
I made a mistake in the previous PR #1020, pending merging.

AntoniRomera

LGTM

FernandoRomera · 2024-08-06T17:01:10Z

@pedrobaeza
Done, can you review and merge?.

pedrobaeza · 2024-08-06T18:50:36Z

edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py

@@ -238,7 +251,7 @@ def _get_products_data(self):
                    "UP": "750.0",
                    "Total": "1500.0",
                },
-                "taxes": [],
+                "taxes": [{"Type": False, "Rate": "15.0"}],


Why this change and the following one?

Simply compare the result with the expected result and match the values.
It seems to assign a default value to the tax_ids field in the invoice lines if it does not have one and therefore all values change. I can leave it like this or set tax_ids: False, as you prefer.

Yes, we should fix it and don't leave this to the "default behavior in some cases".

Done, set to 15% tax for lines without.

On contrary, what I say is to have it empty.

pedrobaeza · 2024-08-06T18:50:44Z

/ocabot migration edi_voxel_account_invoice_oca

pedrobaeza · 2024-08-07T15:26:19Z

edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py

@@ -238,7 +251,7 @@ def _get_products_data(self):
                    "UP": "750.0",
                    "Total": "1500.0",
                },
-                "taxes": [],
+                "taxes": [{"Type": False, "Rate": "15.0"}],


On contrary, what I say is to have it empty.

edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py

pedrobaeza · 2024-08-07T15:53:13Z

edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py

-        return []
+        return [
+            {
+                "SupplierClientID": "C01",


Why is this changing as well?

Add another default value, field "partner_shipping_id": False,

edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-08-08T07:56:04Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1019-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-08T08:00:56Z

Congratulations, your PR was merged at 6da056c. Thanks a lot for contributing to OCA. ❤️

sergio-teruel and others added 12 commits August 6, 2024 10:31

[MIG] edi_voxel_account_invoice: Migration to v15.0

a4333b5

[UPD] Update edi_voxel_account_invoice_oca.pot

0bcc36a

[FIX] edi_voxel_account_invoice_oca: Associate channels to methods vi…

57e998b

…a XML Associate `queue job channels` with delayable methods via XML and add migration script fixup with edi_voxel_account_invoice_oca

[UPD] README.rst

7b718ac

[UPD] README.rst

99de275

Update translation files

331fc65

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-15.0/edi-15.0-edi_voxel_account_invoice_oca Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_voxel_account_invoice_oca/

[IMP] edi_voxel_account_invoice_oca: test performance improvement

2dadd4d

- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates

dd040b0

Translated using Weblate (Spanish)

fa85f08

Currently translated at 100.0% (32 of 32 strings) Translation: edi-15.0/edi-15.0-edi_voxel_account_invoice_oca Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_voxel_account_invoice_oca/es/

[FIX] edi_voxel_account_invoice_oca: Intercept post low level method

e3d4244

Inheriting post instead of _post makes that certain roots followed to post invoices didn't trigger the Voxel sending, which is incorrect. Let's inherit the low level method then. TT49512

[BOT] post-merge updates

1014bf3

[IMP] edi_voxel_account_invoice_oca: pre-commit auto fixes

35f675b

FernandoRomera mentioned this pull request Aug 6, 2024

Migration to version 17.0 #857

Open

15 tasks

FernandoRomera force-pushed the 17.0-mig-edi_voxel_account_invoice_oca branch 5 times, most recently from f607e23 to d5f6037 Compare August 6, 2024 12:06

FernandoRomera force-pushed the 17.0-mig-edi_voxel_account_invoice_oca branch 2 times, most recently from 16a931e to ec03bf3 Compare August 6, 2024 14:37

AntoniRomera approved these changes Aug 6, 2024

View reviewed changes

pedrobaeza reviewed Aug 6, 2024

View reviewed changes

OCA-git-bot added this to the 17.0 milestone Aug 6, 2024

FernandoRomera force-pushed the 17.0-mig-edi_voxel_account_invoice_oca branch 5 times, most recently from 8d6b14b to 9ebe399 Compare August 7, 2024 09:34

pedrobaeza reviewed Aug 7, 2024

View reviewed changes

FernandoRomera force-pushed the 17.0-mig-edi_voxel_account_invoice_oca branch 3 times, most recently from 741b02a to 06ab8c2 Compare August 7, 2024 15:46

pedrobaeza reviewed Aug 7, 2024

View reviewed changes

FernandoRomera force-pushed the 17.0-mig-edi_voxel_account_invoice_oca branch from 06ab8c2 to ec4ab36 Compare August 7, 2024 16:07

[MIG] edi_voxel_account_invoice_oca: Migration to 17.0

136ddc3

FernandoRomera force-pushed the 17.0-mig-edi_voxel_account_invoice_oca branch from ec4ab36 to 136ddc3 Compare August 7, 2024 16:11

pedrobaeza approved these changes Aug 8, 2024

View reviewed changes

OCA-git-bot added the approved label Aug 8, 2024

OCA-git-bot added the bot is merging ⏳ label Aug 8, 2024

OCA-git-bot merged commit 996eb67 into OCA:17.0 Aug 8, 2024
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019

[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019

FernandoRomera commented Aug 6, 2024

FernandoRomera commented Aug 6, 2024

pedrobaeza commented Aug 6, 2024

FernandoRomera commented Aug 6, 2024 •

edited by pedrobaeza

Loading

FernandoRomera commented Aug 6, 2024

FernandoRomera commented Aug 6, 2024

AntoniRomera left a comment

FernandoRomera commented Aug 6, 2024

pedrobaeza Aug 6, 2024

FernandoRomera Aug 7, 2024

pedrobaeza Aug 7, 2024

FernandoRomera Aug 7, 2024

pedrobaeza Aug 7, 2024

pedrobaeza commented Aug 6, 2024

pedrobaeza Aug 7, 2024

pedrobaeza Aug 7, 2024

FernandoRomera Aug 7, 2024 •

edited

Loading

pedrobaeza left a comment

OCA-git-bot commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019

[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019

Conversation

FernandoRomera commented Aug 6, 2024

FernandoRomera commented Aug 6, 2024

pedrobaeza commented Aug 6, 2024

FernandoRomera commented Aug 6, 2024 • edited by pedrobaeza Loading

FernandoRomera commented Aug 6, 2024

FernandoRomera commented Aug 6, 2024

AntoniRomera left a comment

Choose a reason for hiding this comment

FernandoRomera commented Aug 6, 2024

pedrobaeza Aug 6, 2024

Choose a reason for hiding this comment

FernandoRomera Aug 7, 2024

Choose a reason for hiding this comment

pedrobaeza Aug 7, 2024

Choose a reason for hiding this comment

FernandoRomera Aug 7, 2024

Choose a reason for hiding this comment

pedrobaeza Aug 7, 2024

Choose a reason for hiding this comment

pedrobaeza commented Aug 6, 2024

pedrobaeza Aug 7, 2024

Choose a reason for hiding this comment

pedrobaeza Aug 7, 2024

Choose a reason for hiding this comment

FernandoRomera Aug 7, 2024 • edited Loading

Choose a reason for hiding this comment

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Aug 8, 2024

OCA-git-bot commented Aug 8, 2024

FernandoRomera commented Aug 6, 2024 •

edited by pedrobaeza

Loading

FernandoRomera Aug 7, 2024 •

edited

Loading