-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019
[17.0][MIG] edi_voxel_account_invoice_oca: Migration to 17.0 #1019
Conversation
…a XML Associate `queue job channels` with delayable methods via XML and add migration script fixup with edi_voxel_account_invoice_oca
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-15.0/edi-15.0-edi_voxel_account_invoice_oca Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_voxel_account_invoice_oca/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (32 of 32 strings) Translation: edi-15.0/edi-15.0-edi_voxel_account_invoice_oca Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-edi_voxel_account_invoice_oca/es/
Inheriting post instead of _post makes that certain roots followed to post invoices didn't trigger the Voxel sending, which is incorrect. Let's inherit the low level method then. TT49512
@pedrobaeza Run manifestoo -d . check-dev-status --default-dev-status=Beta |
I think you should promote instead |
@pedrobaeza |
f607e23
to
d5f6037
Compare
@pedrobaeza |
16a931e
to
ec03bf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pedrobaeza |
@@ -238,7 +251,7 @@ def _get_products_data(self): | |||
"UP": "750.0", | |||
"Total": "1500.0", | |||
}, | |||
"taxes": [], | |||
"taxes": [{"Type": False, "Rate": "15.0"}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change and the following one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply compare the result with the expected result and match the values.
It seems to assign a default value to the tax_ids field in the invoice lines if it does not have one and therefore all values change. I can leave it like this or set tax_ids: False, as you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should fix it and don't leave this to the "default behavior in some cases".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, set to 15% tax for lines without.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On contrary, what I say is to have it empty.
/ocabot migration edi_voxel_account_invoice_oca |
8d6b14b
to
9ebe399
Compare
@@ -238,7 +251,7 @@ def _get_products_data(self): | |||
"UP": "750.0", | |||
"Total": "1500.0", | |||
}, | |||
"taxes": [], | |||
"taxes": [{"Type": False, "Rate": "15.0"}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On contrary, what I say is to have it empty.
edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py
Outdated
Show resolved
Hide resolved
741b02a
to
06ab8c2
Compare
return [] | ||
return [ | ||
{ | ||
"SupplierClientID": "C01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changing as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add another default value, field "partner_shipping_id": False,
edi_voxel_account_invoice_oca/tests/test_voxel_account_invoice.py
Outdated
Show resolved
Hide resolved
06ab8c2
to
ec4ab36
Compare
ec4ab36
to
136ddc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 6da056c. Thanks a lot for contributing to OCA. ❤️ |
No description provided.