-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][FIX] base_import_pdf_by_template: Improve the import process to account for fixed values #1033
[15.0][FIX] base_import_pdf_by_template: Improve the import process to account for fixed values #1033
Conversation
6222978
to
b2c1fab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
base_import_pdf_by_template/wizards/wizard_base_import_pdf_upload.py
Outdated
Show resolved
Hide resolved
…unt for fixed values When fixed values are defined, default_x was used in the context of Form() but in some cases this was not respected (for example if the value was changed in an onchange, warehouse_id field of sale orders). We changed the way of creating the records to always take into account the fixed values. TT50650
b2c1fab
to
10e5c1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! |
This PR has the |
1 similar comment
This PR has the |
Congratulations, your PR was merged at d59e4bb. Thanks a lot for contributing to OCA. ❤️ |
Improve the import process to account for fixed values
When fixed values are defined, default_x was used in the context of Form() but in some cases this was not respected (for example if the value was changed in an onchange,
warehouse_id
field of sale orders).We changed the way of creating the records to always take into account the fixed values.
Please @pedrobaeza and @pilarvargas-tecnativa can you review it?
@Tecnativa TT50650