Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][FIX] fix issue pypdf 5.0 dropped support for python<=3.7 #1042

Merged
merged 1 commit into from
Oct 9, 2024
Merged

[12.0][FIX] fix issue pypdf 5.0 dropped support for python<=3.7 #1042

merged 1 commit into from
Oct 9, 2024

Conversation

thienvh332
Copy link
Contributor

No description provided.

@thienvh332 thienvh332 marked this pull request as ready for review September 30, 2024 03:49
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella
etobella reviewed Oct 7, 2024
View reviewed changes
requirements.txt Outdated
@@ -1,4 +1,7 @@
# generated from manifests external_dependencies
# The factur-x library requires pypdf >=3.15.0
# pypdf 5.0 dropped support for python<=3.7
pypdf>=3.15.0,<5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't edit requirements.txt directly. Use test-requirements for that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @etobella ,
I updated it.

@etobella
Copy link
Member

etobella commented Oct 9, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-1042-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 059f27b into OCA:12.0 Oct 9, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 059f27b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thienvh332 @OCA-git-bot @etobella @bosd @MiquelRForgeFlow