Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] base_business_document_import: Improve Coverage #845

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from
Open

[14.0][IMP] base_business_document_import: Improve Coverage #845

wants to merge 2 commits into from

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Nov 1, 2023

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@bosd bosd marked this pull request as ready for review November 1, 2023 22:07
@bosd bosd changed the title [IMP] base_business_document_import: Improve Coverage [14.0][IMP] base_business_document_import: Improve Coverage Nov 2, 2023
@bosd bosd mentioned this pull request Nov 3, 2023
Open
bofiltd
bofiltd approved these changes Nov 27, 2023
View reviewed changes
Copy link

@bofiltd bofiltd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dranyel-Bosd
Dranyel-Bosd approved these changes Nov 28, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@bosd
Copy link
Contributor Author

bosd commented Jan 13, 2024

@alexis-via Can you merge? 🙏

@bosd
Copy link
Contributor Author

bosd commented Feb 4, 2024

@simahawk Can you please merge?

@bosd
Copy link
Contributor Author

bosd commented Mar 13, 2024

@alexis-via Can you merge?

simahawk
simahawk reviewed Mar 13, 2024
View reviewed changes
base_business_document_import/tests/test_business_document_import.py Outdated
from odoo.exceptions import UserError
from odoo.tests import tagged
from odoo.tests.common import TransactionCase

_logger = logging.getLogger("odoo.tests.test_module_operations")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the usage of this logger

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk I reverted it. Is it ok now?

@simahawk
Copy link
Contributor

@simahawk Can you please merge?

Sorry, I have a huge pile of pings/PRs to review... I missed this one.
Don't hesitate to ping me more than once if you get stuck 😉

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 14, 2024
@bosd bosd force-pushed the 14.0-imp-test-base_business_document_import branch from b063479 to feb4ca2 Compare July 15, 2024 05:26
@bosd bosd force-pushed the 14.0-imp-test-base_business_document_import branch from feb4ca2 to 49fcaed Compare July 15, 2024 05:28
@bosd
Copy link
Contributor Author

bosd commented Jul 15, 2024

It is ready now, bot please remove the stale label.

@bosd bosd requested a review from simahawk July 16, 2024 12:18
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 21, 2024
@bosd
Copy link
Contributor Author

bosd commented Jul 30, 2024

Don't hesitate to ping me more than once if you get stuck 😉

@simahawk This one is stuck. Can you please merge?

@bosd
Copy link
Contributor Author

bosd commented Sep 30, 2024

It has the approved label.. can we get a merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bofiltd bofiltd bofiltd approved these changes

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

@simahawk simahawk Awaiting requested review from simahawk

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bosd @OCA-git-bot @simahawk @bofiltd @Dranyel-Bosd