[FIX] fieldservice_account_analytic: automatically fill Contact in FS…

…M Order

When customer_id is not set in the order we have:

> "customer_id" not in vals and order.customer_id is False
> False

> "customer_id" not in vals and not order.customer_id
> True

fieldservice_account_analytic/models/fsm_order.py

@@ -58,6 +58,6 @@ def _onchange_customer_id_location(self):
     def write(self, vals):
         res = super(FSMOrder, self).write(vals)
         for order in self:
-            if "customer_id" not in vals and order.customer_id is False:
+            if "customer_id" not in vals and not order.customer_id:
                 order.customer_id = order.location_id.customer_id.id
         return res

fieldservice_account_analytic/readme/CONTRIBUTORS.rst

@@ -1,3 +1,4 @@
 * Michael Allen <mallen@opensourceintegrators.com>
 * Serpent Consulting Services Pvt. Ltd. <support@serpentcs.com>
 * Brian McMaster <brian@mcmpest.com>
+* Alex Comba <alex.comba@agilebg.com>

fieldservice_stock_account/tests/test_fsm_stock_account.py

@@ -77,7 +77,5 @@ def test_fsm_order(self):
         SR_2.action_confirm()
         fsm_order2.account_no_invoice()
         fsm_order2.bill_to = "contact"
-        with self.assertRaises(UserError):
-            fsm_order2.account_no_invoice()
-        fsm_order2.customer_id = self.test_partner.id
+        self.AssertEqual(fsm_order2.customer_id, fsm_order2.location_id.customer_id)
         fsm_order2.account_no_invoice()