-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] fieldservice #1141
[17.0][MIG] fieldservice #1141
Conversation
/ocabot migration fieldservice |
bcda951
to
04e8ad9
Compare
@brian10048 #1141 Has been merged. Please fix the pre-commit issues with this PR so we can test and review |
Currently translated at 1.7% (9 of 528 strings) Translation: field-service-12.0/field-service-12.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 11.9% (63 of 528 strings) Translation: field-service-12.0/field-service-12.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 39.2% (207 of 528 strings) Translation: field-service-12.0/field-service-12.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 51.3% (271 of 528 strings) Translation: field-service-12.0/field-service-12.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 64.4% (340 of 528 strings) Translation: field-service-12.0/field-service-12.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 66.9% (353 of 528 strings) Translation: field-service-12.0/field-service-12.0-fieldservice Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
cd4c7cd
to
8d68716
Compare
@SMaciasOSI All set for testing and review |
fieldservice/views/fsm_team.xml
Outdated
<field name="name">Orders</field> | ||
<field name="res_model">fsm.order</field> | ||
<field name="view_mode">kanban,tree,form,calendar</field> | ||
<field name="context">{'default_team_id': id}</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brian10048 This line is giving me an error when I try to click the "To do" button in the kanban view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been solved
0da7474
to
ca52900
Compare
@brian10048 I have tested your changes on runboat, the JS error has disappeared. Now, the precommit and tests checks are not being triggered for some reason. Any idea why? |
ca52900
to
c773824
Compare
c773824
to
47c0592
Compare
@SMaciasOSI I think it was an issue with Github. I bumped it just now and it is running the checks |
@brian10048 All seems good. As soon as the codecov checks pass, I'll approve this PR. |
@SMaciasOSI I think I'm out of hours budget to work anymore on this to increase the coverage above 98.8% 😆 There are only a few lines which are partially covered, with no lines missed |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at ebdd49f. Thanks a lot for contributing to OCA. ❤️ |
Ready for functional testing on runboat.