Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fieldservice #1141

Merged
merged 396 commits into from
Dec 18, 2023
Merged

Conversation

brian10048
Copy link
Contributor

@brian10048 brian10048 commented Nov 15, 2023

Ready for functional testing on runboat.

@brian10048 brian10048 added this to the 17.0 milestone Nov 15, 2023
@brian10048 brian10048 self-assigned this Nov 15, 2023
@brian10048
Copy link
Contributor Author

/ocabot migration fieldservice

@SMaciasOSI
Copy link
Contributor

@brian10048 #1141 Has been merged. Please fix the pre-commit issues with this PR so we can test and review

patrickrwilson and others added 13 commits November 27, 2023 09:24
Currently translated at 1.7% (9 of 528 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 11.9% (63 of 528 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 39.2% (207 of 528 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 51.3% (271 of 528 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 64.4% (340 of 528 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
Currently translated at 66.9% (353 of 528 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice/es_CL/
@brian10048 brian10048 marked this pull request as ready for review November 27, 2023 16:22
@brian10048 brian10048 force-pushed the 17.0-mig-fieldservice branch 5 times, most recently from cd4c7cd to 8d68716 Compare November 27, 2023 17:08
@brian10048
Copy link
Contributor Author

@SMaciasOSI All set for testing and review

<field name="name">Orders</field>
<field name="res_model">fsm.order</field>
<field name="view_mode">kanban,tree,form,calendar</field>
<field name="context">{'default_team_id': id}</field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian10048 This line is giving me an error when I try to click the "To do" button in the kanban view
Captura desde 2023-11-27 12-20-37

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been solved

@brian10048 brian10048 force-pushed the 17.0-mig-fieldservice branch 4 times, most recently from 0da7474 to ca52900 Compare November 27, 2023 20:18
@SMaciasOSI
Copy link
Contributor

@brian10048 I have tested your changes on runboat, the JS error has disappeared. Now, the precommit and tests checks are not being triggered for some reason. Any idea why?

@brian10048
Copy link
Contributor Author

@SMaciasOSI I think it was an issue with Github. I bumped it just now and it is running the checks

@SMaciasOSI
Copy link
Contributor

@brian10048 All seems good. As soon as the codecov checks pass, I'll approve this PR.

@brian10048
Copy link
Contributor Author

@SMaciasOSI I think I'm out of hours budget to work anymore on this to increase the coverage above 98.8% 😆

There are only a few lines which are partially covered, with no lines missed

@max3903
Copy link
Member

max3903 commented Dec 18, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1141-by-max3903-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d1e68d4 into OCA:17.0 Dec 18, 2023
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ebdd49f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.