[17.0][MIG] fieldservice_agreement: Migration to 17.0 #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[UPD] README.rst
[UPD] README.rst
* [IMP] fieldservice_agreement [UPD] README.rst
… move views to agreement module 3. improve location heirarchy name construction
[UPD] README.rst
[UPD] README.rst
[IMP] fieldservice_vehicle_stock
[UPD] Update fieldservice_agreement.pot Added translation using Weblate (Portuguese (Brazil)) Added translation using Weblate (Spanish (Chile)) Translated using Weblate (Spanish (Chile)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es_CL/ Added translation using Weblate (German) Translated using Weblate (German) Currently translated at 6.7% (1 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ Translated using Weblate (German) Currently translated at 26.7% (4 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ Translated using Weblate (German) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ [ADD] Spanish (es) translation Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Spanish) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Added translation using Weblate (Spanish (Argentina)) Translated using Weblate (Spanish (Argentina)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es_AR/
[MIG] Black [MIG] Added more coverage to tests [MIG] Add contract to dependancy Add maintainer Update CONTRIBUTORS.rst add eol
It will be better to properly fix by not using replace I guess
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-14.0/field-service-14.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_agreement/
Currently translated at 100.0% (19 of 19 strings) Translation: field-service-14.0/field-service-14.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_agreement/es_AR/
imlopes
force-pushed
the
17.0-mig-fieldservice_agreement
branch
2 times, most recently
from
7e0abc0
to
1f97aa3
Compare
imlopes
force-pushed
the
17.0-mig-fieldservice_agreement
branch
from
1f97aa3
to
ae16354
Compare
yankinmax
approved these changes
Sep 16, 2024
|
Can you take care of this :
Otherwise we're not supporting the same features that were before the migration. |
I did on a new commit |
As we're removing the dependency on `agreement_serviceprofile`, a new glue module is added to keep the same features than before.
imlopes
force-pushed
the
17.0-mig-fieldservice_agreement
branch
from
fb69f70
to
2dfb703
Compare
imlopes
force-pushed
the
17.0-mig-fieldservice_agreement
branch
2 times, most recently
from
9128787
to
8b034c3
Compare
imlopes
force-pushed
the
17.0-mig-fieldservice_agreement
branch
from
8b034c3
to
4dc8a54
Compare
|
@imlopes Can you split this pull request and have one for each module? |
yankinmax
reviewed
Sep 23, 2024
| @@ -24,7 +24,7 @@ | |||
| type="object" | |||
| class="oe_stat_button" | |||
| icon="fa-laptop" | |||
| context="{'default_agreement_id': active_id}" | |||
| context="{'default_agreement_id': id}" | |||
There was a problem hiding this comment.
I got from here :
If you are using active_id, active_ids or active_model in your views (for example, for a smart-button context), you should replace them by the corresponding good practices:
id instead of active_id. Hard-coded model name instead of active_model. active_ids doesn't have direct replacement candidate. It will depend on what you want to achieve. It's a weird case though.
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
yankinmax
reviewed
Sep 23, 2024
| agreements = self.env["agreement"].search( | ||
| [("fsm_location_id", "=", loc.id)] | ||
| ) | ||
| ids = [] |
There was a problem hiding this comment.
agreement_ids = agreements.ids
service_profiles = self.env['agreement.serviceprofile'].search(
[('agreement_id', 'in', agreement_ids)]
)
ids = list(set(service_profiles.ids))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
agreement:
Adding new
fieldservice_agreement_serviceprofile(did in a new commit❓ )Removing dependency from
agreement_serviceprofileonfieldservice_agreementand adding a new glue module :agreement_serviceprofile: OCA/agreement#39
...