[17.0][MIG] fieldservice_sale_recurring: Migration to 17.0 #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian10048
requested changes
Sep 16, 2024
yankinmax
reviewed
Sep 17, 2024
yankinmax
approved these changes
Sep 17, 2024
imlopes
force-pushed
the
17.0-mig-fieldservice_sale_recurring
branch
2 times, most recently
from
a7b52c2
to
db05895
Compare
gurneyalex
reviewed
Sep 18, 2024
|
hello @brian10048 Can you update your review? |
gurneyalex
reviewed
Sep 20, 2024
There was a problem hiding this comment.
@imlopes Can you also squash the translation commits (see https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate)
imlopes
force-pushed
the
17.0-mig-fieldservice_sale_recurring
branch
from
db05895
to
654bff5
Compare
Co-Authored-By: brian10048 <brian@mcmpest.com>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-12.0/field-service-12.0-fieldservice_sale_recurring Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_sale_recurring/
- Was not calling super properly and FSM orders on the sale line that were not recurring orders were not being created. - Delete unused computed field.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/
Currently translated at 100.0% (18 of 18 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es/
Currently translated at 100.0% (18 of 18 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/it/
Currently translated at 100.0% (18 of 18 strings) Translation: field-service-15.0/field-service-15.0-fieldservice_sale_recurring Translate-URL: https://translation.odoo-community.org/projects/field-service-15-0/field-service-15-0-fieldservice_sale_recurring/es_AR/
…generate wrong fsm_order (ex: Assigned To not set, start date wrong, recuring info not set, ...)
…d fsm order for recurring order
Do not copy FSM Order or FSM Recurring Orders on sale order line
imlopes
force-pushed
the
17.0-mig-fieldservice_sale_recurring
branch
from
654bff5
to
71f0588
Compare
|
@brian10048 Can you help us here? |
max3903
approved these changes
Sep 23, 2024
brian10048
approved these changes
Sep 23, 2024
|
Working as intended. Thank you! |
|
/ocabot merge nobump |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f330d83. Thanks a lot for contributing to OCA. ❤️ |
imlopes
commented
Oct 30, 2024
| def _prepare_invoice_line(self, **optional_values): | ||
| res = super()._prepare_invoice_line(**optional_values) | ||
| if self.fsm_recurring_id: | ||
| fsm_orders = self._get_invoiceable_fsm_order() |
There was a problem hiding this comment.
It seems this method was added here : b6fa0fb#diff-39a34800cd8567f4f4bc2657da63a2c24753af76b678249c2837f9ba6cc9f944 and the code was migrated (to 15.0 and here to 17.0) with this call but I couldn't find the method.
Am I missing something ?
@max3903 @gurneyalex
There was a problem hiding this comment.
@imlopes Good question.
@brian10048 Can you help?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.