[16.0][MIG] fieldservice_portal: Migration to 16.0 #1224

anusriNPS · 2024-10-15T15:19:31Z

MIgrating fieldservice_portal to 16.0 version

max3903 · 2024-10-16T05:06:04Z

/ocabot migration fieldservice_portal

PicchiSeba

Code review: minor fixes in the views

PicchiSeba · 2024-10-17T11:47:28Z

fieldservice_portal/views/fsm_order_template.xml

+                                    <em class="font-weight-normal text-muted">
+                                        Work Orders for
+                                        <t
+                                            t-esc="searchbar_groupby[groupby]['label']"


t-esc has been deprecated in 15.0 in favour of t-out

PicchiSeba · 2024-10-17T11:47:42Z

fieldservice_portal/views/fsm_order_template.xml

+                                <tr>
+                                    <td>
+                                        <a t-attf-href="/my/workorder/#{order.id}">
+                                            <t t-esc="order.name" />


PicchiSeba · 2024-10-17T11:47:50Z

fieldservice_portal/views/fsm_order_template.xml

+                                        </a>
+                                    </td>
+                                    <td>
+                                        <t t-esc="order.description" />


PicchiSeba · 2024-10-17T11:47:57Z

fieldservice_portal/views/fsm_order_template.xml

+                                    </td>
+                                    <td>
+                                        <t
+                                            t-esc="order.sudo().location_id.display_name"


PicchiSeba · 2024-10-17T11:48:14Z

fieldservice_portal/views/fsm_order_template.xml

+                                        />
+                                    </td>
+                                    <td>
+                                        <t t-esc="order.type.name" />


PicchiSeba · 2024-10-17T11:48:21Z

fieldservice_portal/views/fsm_order_template.xml

+                                        <t t-esc="order.type.name" />
+                                    </td>
+                                    <td>
+                                        <t t-esc="order.stage_id.name" />


PicchiSeba · 2024-10-17T11:48:30Z

fieldservice_portal/views/fsm_order_template.xml

+                            </div>
+                            <div class="col-md-6">
+                                <strong>Stage:</strong>
+                                <t t-esc="order.stage_id.name" />


PicchiSeba · 2024-10-17T11:48:38Z

fieldservice_portal/views/portal_template.xml

+                <t t-else="">Work Orders</t>
+            </li>
+            <li t-if="fsm_order" class="breadcrumb-item active">
+                <t t-esc="fsm_order.name" />


anusriNPS · 2024-10-17T12:59:58Z

Verified views after using t-out instead of t-esc and all are intact

PicchiSeba · 2024-10-17T13:11:42Z

We might need to add some tests, the coverage is quite low.

max3903 · 2024-10-24T15:26:48Z

@anusriNPS I don't see Work Orders on the portal:

What did I miss? A configuration step that should be added to the readme fragments?

anusriNPS · 2024-10-24T16:02:48Z

@max3903 Work orders are listed while using API /my/workorders, is this API you are looking for or is it required work order to be listed on homepage? Currently, as per available changes, on home page workorders are not displayed

max3903 · 2024-10-24T16:23:14Z

@anusriNPS My expectation is that the customer can create and track their FSM orders on the portal. So it should appear on the portal page.

This is my opinion. Others can share theirs...

max3903 · 2024-10-24T16:24:12Z

Maybe you can document that this is not available and provide the direct path in the readme fragments.

brian10048 · 2024-10-24T16:29:30Z

@anusriNPS My expectation is that the customer can create and track their FSM orders on the portal. So it should appear on the portal page.

This is my opinion. Others can share theirs...

My expectation is the same. As a customer, you would be able to view your FSM orders from the portal home page just like other documents

PicchiSeba

Code review: following the maintainer suggestions we should add the necessary button to the main portal view

It can be accessed at /my with the portal user

PicchiSeba · 2024-10-25T12:38:41Z

fieldservice_portal/controllers/fsm_order_portal.py

+
+
+class CustomerPortal(CustomerPortal):
+    def _prepare_portal_layout_values(self):


issue: missing from Controller

Suggested change

def _prepare_portal_layout_values(self):

def _prepare_home_portal_values(self, counters):

values = super()._prepare_home_portal_values(counters)

if "fsm_order_count" in counters:

fsm_order_model = request.env["fsm.order"]

fsm_order_count = (

fsm_order_model.search_count([])

if fsm_order_model.check_access_rights("read", raise_exception=False)

else 0

)

values["fsm_order_count"] = fsm_order_count

return values

def _prepare_portal_layout_values(self):

PicchiSeba · 2024-10-25T12:41:44Z

fieldservice_portal/views/portal_template.xml

+    >
+        <xpath expr="//div[hasclass('o_portal_docs')]" position="inside">
+            <t t-if="fsm_order_count" t-call="portal.portal_docs_entry">
+              <t t-set="title">Work Orders</t>
+              <t t-set="url" t-value="'/my/workorders'" />
+              <t t-set="count" t-value="fsm_order_count" />
+            </t>


issue: missing from portal view

Suggested change

>

<xpath expr="//div[hasclass('o_portal_docs')]" position="inside">

<t t-if="fsm_order_count" t-call="portal.portal_docs_entry">

<t t-set="title">Work Orders</t>

<t t-set="url" t-value="'/my/workorders'" />

<t t-set="count" t-value="fsm_order_count" />

</t>

customize_show="True"

>

<xpath expr="//div[hasclass('o_portal_docs')]" position="inside">

<t t-call="portal.portal_docs_entry">

<t t-set="title">Work Orders</t>

<t t-set="url" t-value="'/my/workorders'" />

<t t-set="placeholder_count" t-value="'fsm_order_count'" />

</t>

PicchiSeba · 2024-10-25T14:25:30Z

fieldservice_portal/static/src/js/fsm_order_portal.js

@@ -0,0 +1,13 @@
+/** @odoo-module */


issue: pre-commit is whining because the file must be renamed fsm_order_portal.esm.js

Updated extension with "esm.js". Thank you @PicchiSeba

PicchiSeba

Code review: LGTM

peluko00

LGTM

peluko00 · 2024-10-28T12:20:40Z

Seems i'ts ready to merge @max3903

max3903 · 2024-10-28T12:33:22Z

/ocabot merge nobump

OCA-git-bot · 2024-10-28T12:33:29Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1224-by-max3903-bump-nobump, awaiting test results.

OCA-git-bot · 2024-10-28T12:41:34Z

Congratulations, your PR was merged at 3b96423. Thanks a lot for contributing to OCA. ❤️

renda-dev and others added 2 commits October 15, 2024 16:49

[ADD] fieldservice_portal

5d5d6be

[IMP] fieldservice_portal: pre-commit stuff

09eef27

anusriNPS marked this pull request as draft October 15, 2024 15:20

anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch 2 times, most recently from 34469f2 to ff69dce Compare October 15, 2024 15:37

max3903 added this to the 16.0 milestone Oct 16, 2024

max3903 added needs review migration labels Oct 16, 2024

max3903 self-assigned this Oct 16, 2024

max3903 changed the title ~~[16.0] [MIG] fieldservice portal: Migration to 16.0~~ [16.0][MIG] fieldservice_portal: Migration to 16.0 Oct 16, 2024

OCA-git-bot mentioned this pull request Oct 16, 2024

Migration to version 16.0 #963

Open

48 tasks

anusriNPS marked this pull request as ready for review October 16, 2024 10:24

PicchiSeba suggested changes Oct 17, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch from ff69dce to a3405a4 Compare October 17, 2024 12:50

anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch from a3405a4 to 9c29318 Compare October 23, 2024 13:47

max3903 added the need tests label Oct 23, 2024

anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch 6 times, most recently from 53a537d to 4926016 Compare October 24, 2024 14:24

max3903 removed the need tests label Oct 24, 2024

max3903 requested a review from PicchiSeba October 24, 2024 15:14

PicchiSeba suggested changes Oct 25, 2024

View reviewed changes

anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch 2 times, most recently from e202162 to 53b631b Compare October 25, 2024 13:53

PicchiSeba suggested changes Oct 25, 2024

View reviewed changes

max3903 approved these changes Oct 25, 2024

View reviewed changes

[MIG] fieldservice_portal: Migation to 16.0

df8b7ad

anusriNPS force-pushed the 16.0-mig-fieldservice_portal branch from 53b631b to df8b7ad Compare October 25, 2024 15:23

PicchiSeba approved these changes Oct 28, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 28, 2024

peluko00 approved these changes Oct 28, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Oct 28, 2024

OCA-git-bot merged commit df95c53 into OCA:16.0 Oct 28, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 28, 2024

PicchiSeba deleted the 16.0-mig-fieldservice_portal branch October 28, 2024 12:45



		class CustomerPortal(CustomerPortal):
		def _prepare_portal_layout_values(self):

-    def _prepare_portal_layout_values(self):
+    def _prepare_home_portal_values(self, counters):
+        values = super()._prepare_home_portal_values(counters)
+        if "fsm_order_count" in counters:
+            fsm_order_model = request.env["fsm.order"]
+            fsm_order_count = (
+                fsm_order_model.search_count([])
+                if fsm_order_model.check_access_rights("read", raise_exception=False)
+                else 0
+            )
+            values["fsm_order_count"] = fsm_order_count
+        return values
+    def _prepare_portal_layout_values(self):

[16.0][MIG] fieldservice_portal: Migration to 16.0 #1224

[16.0][MIG] fieldservice_portal: Migration to 16.0 #1224

Conversation

anusriNPS commented Oct 15, 2024

max3903 commented Oct 16, 2024

PicchiSeba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anusriNPS commented Oct 17, 2024

PicchiSeba commented Oct 17, 2024

max3903 commented Oct 24, 2024 • edited Loading

anusriNPS commented Oct 24, 2024 • edited Loading

max3903 commented Oct 24, 2024

max3903 commented Oct 24, 2024

brian10048 commented Oct 24, 2024

PicchiSeba left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PicchiSeba Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PicchiSeba left a comment

Choose a reason for hiding this comment

peluko00 left a comment

Choose a reason for hiding this comment

peluko00 commented Oct 28, 2024

max3903 commented Oct 28, 2024

OCA-git-bot commented Oct 28, 2024

OCA-git-bot commented Oct 28, 2024

max3903 commented Oct 24, 2024 •

edited

Loading

anusriNPS commented Oct 24, 2024 •

edited

Loading

PicchiSeba left a comment •

edited

Loading

PicchiSeba Oct 25, 2024 •

edited

Loading