-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] helpdesk_mgmt_timesheet : Migration to 15.0 #425
Conversation
d353906
to
8a8be45
Compare
/ocabot migration helpdesk_mgmt_timesheet |
There's no issue in this repo with the title 'Migration to version 15.0' and the milestone 15.0, so not possible to add the comment. |
f979cac
to
8a8be45
Compare
8a8be45
to
84dead0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionaly tested 👍
For code review, see comment.
Also and not blocking, I propose as improvement adding widget="many2one_avatar_user"
to timesheet_helpdesk_ticket_view_form
view for user_id
timesheets field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include (cherry-pick) #468 here?
Hi, could you also include this new change from v14: #477? Thanks |
7d04443
to
1639aa2
Compare
@LoisRForgeFlow Both changes have been cherry picked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LG!
This PR has the |
Hello @pedrobaeza is it possible to merge this PR? |
/ocabot merge nobump |
@pedrobaeza The merge process could not start, because command `git merge --no-ff -m 'Merge PR #425 into 15.0 Signed-off-by pedrobaeza' tmp-pr-425` failed with output:
|
/ocabot merge nobump |
@pedrobaeza The merge process could not start, because command `git merge --no-ff -m 'Merge PR #425 into 15.0 Signed-off-by pedrobaeza' tmp-pr-425` failed with output:
|
@dalonsod can you please rebase and re-push to see if we remove the problem? |
…lpdesk.ticket.team
Currently translated at 100.0% (32 of 32 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_timesheet/it/
Currently translated at 100.0% (32 of 32 strings) Translation: helpdesk-14.0/helpdesk-14.0-helpdesk_mgmt_timesheet Translate-URL: https://translation.odoo-community.org/projects/helpdesk-14-0/helpdesk-14-0-helpdesk_mgmt_timesheet/it/
…e_control Also set the version to 15.0.1.0.0 as indicated in OCA’s migration guide.
7eb0a67
to
64cb921
Compare
If `helpdesk_mgmt_project` is installed without `helpdesk_mgmt_timesheet`, an `AttributeError` is raised when submitting a new ticket
64cb921
to
644a3f2
Compare
Done, I’ve also squashed some bot/translation commits. |
@pedrobaeza could you try again? |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 77cdcc6. Thanks a lot for contributing to OCA. ❤️ |
Thanks!! |
Rebase of #338