-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] hr_expense_tax_adjust #96
base: 14.0
Are you sure you want to change the base?
Conversation
97ecc07
to
51c8580
Compare
dc4c393
to
7f850f1
Compare
92a5c6b
to
efd13e6
Compare
0a440b7
to
525cb6e
Compare
@ps-tubtim the UI of tax amount is not quite inline with other fields, may be you need a bit of adjusting it. |
8e7a923
to
80cbf6c
Compare
80cbf6c
to
6f463f3
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
I try this on my local and it's functionally works. Any plan to reopen and merge this ? |
@Saran440 can you open this? |
Thanks for reopening this, few further comments on this.
|
@hitrosol Thank you for review this PR. |
Here is the step to error.
Screen.Recording.2024-06-01.at.13.19.10.mp4 |
second thing, is it okay if the field tax can be accessed by internal user ? Because it's easier to change it in the earlier step, instead by group_account_readonly. Especially if we install the hr_expense_tier_validation where some other users already review and approved but later on the Accountant found that the tax need to be adjusted. Thanks, |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This module allows to edit tax amount before Post Journal Entries on Expenses.
Example