Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] l10n_br_fiscal: adds icms st data #3422

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from
Open

[IMP] l10n_br_fiscal: adds icms st data #3422

wants to merge 2 commits into from

Conversation

mileo
Copy link
Member

@mileo mileo commented Oct 7, 2024 •
edited
Loading

This pull request includes several additions to the l10n_br_fiscal/data/operation_data.xml file to enhance the fiscal operation lines related to different types of sales and resales. The most important changes involve adding new records for various fiscal operations.

Additions to fiscal operation lines:

  • Added fo_venda_venda_st_substituto record for sales by substitute taxpayers. (l10n_br_fiscal/data/operation_data.xml)
  • Added fo_venda_revenda_st_substituto record for resale by substitute taxpayers. (l10n_br_fiscal/data/operation_data.xml)
  • Added fo_venda_revenda_st_substituido record for resale by substituted taxpayers. (l10n_br_fiscal/data/operation_data.xml)
  • Added fo_venda_revenda_st_substituido_sn record for resale by substituted taxpayers under the Simples Nacional regime. (l10n_br_fiscal/data/operation_data.xml)Adiciona dados de configuração para ST.

@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

@antoniospneto
Copy link
Contributor

os testes falharam e não é dado demonstração certo?

@mileo mileo changed the title [IMP] l10n_br_fiscal: adds icms st demo data [IMP] l10n_br_fiscal: adds icms st data Oct 7, 2024
@antoniospneto antoniospneto marked this pull request as draft October 8, 2024 17:02
@Tiago370 Tiago370 force-pushed the 14.0-fiscal-st-data branch 4 times, most recently from 252192d to 0ce193b Compare November 1, 2024 18:46
@DiegoParadeda
Copy link
Contributor

DiegoParadeda commented Nov 1, 2024 •
edited
Loading

image

acho que esse teste teria que testar != zero ao invés de == 4, pois o número de linhas de operação disponíveis pode ser alterado

@Tiago370 Tiago370 force-pushed the 14.0-fiscal-st-data branch from 0ce193b to 9a9869a Compare November 1, 2024 20:19
@Tiago370 Tiago370 force-pushed the 14.0-fiscal-st-data branch from 9a9869a to 3b8077b Compare November 1, 2024 20:50
@mileo mileo marked this pull request as ready for review November 5, 2024 12:50
antoniospneto
antoniospneto approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@antoniospneto antoniospneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marcelsavegnago
marcelsavegnago approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@mileo
Copy link
Member Author

mileo commented Nov 5, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3422-by-mileo-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 5, 2024
@OCA-git-bot
Merge PR #3422 into 14.0
7599669 
Signed-off-by mileo
@OCA-git-bot
Copy link
Contributor

@mileo your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3422-by-mileo-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@marcelsavegnago
Copy link
Member

@rvalyi seria bom um review de vcs já que são os autores.

@marcelsavegnago
Copy link
Member

marcelsavegnago commented Nov 5, 2024 •
edited
Loading

@mileo se puder aguardar o review da akretion, seria bom.

@Tiago370 Tiago370 mentioned this pull request Nov 14, 2024
Open
@mileo
Copy link
Member Author

mileo commented Dec 5, 2024

@mileo se puder aguardar o review da akretion, seria bom.

@rvalyi @renatonlima @mbcosta conseguem revisar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@antoniospneto antoniospneto antoniospneto approved these changes

@rvalyi rvalyi Awaiting requested review from rvalyi

@renatonlima renatonlima Awaiting requested review from renatonlima

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mileo @OCA-git-bot @antoniospneto @DiegoParadeda @marcelsavegnago @Tiago370