[14.0][RFC] l10n_br_nfe: refactor nfce qrcode methods #3542
+53
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rvalyi, @renatonlima, |
mileo
approved these changes
Dec 10, 2024
|
@DiegoParadeda pode dar uma olhada nos testes? |
DiegoParadeda
force-pushed
the
fix/nfce-qrcode
branch
from
974e49e to
b27f38b
Compare
DiegoParadeda
force-pushed
the
fix/nfce-qrcode
branch
from
b27f38b to
3c7d88e
Compare
rvalyi
reviewed
Dec 13, 2024
|
|
||
| copy_invoice.fiscal_document_id.processador_edoc = self.processador_edoc | ||
| copy_invoice.processador_edoc = self.processador_edoc | ||
|
|
There was a problem hiding this comment.
Porque pular linhas antes e depois? Não me parece que essas duas linhas seriam um bloco logico espcial, logo não acho bom pular linhas antes e depois. Eu perdi algo?
|
Pessoal esse PR, da forma que esta no momento resolve os problemas de transmissão. Mas os testes não estão passando, vamos rever isso com calma nas próximas semanas. Quem estiver com problemas em produção pode usar dessa forma por enquanto. |
|
@mileo @DiegoParadeda por se tratar de código compartilhado entre NFe, NFCe, CTe e outros edoc, eh bastante importante acertar esse PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC #3522 + fix duplicate inf.supl
Esse PR corrige um bug atual na geração na NFCe que resulta em falha de schema de XML por falta de inf.supl