-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] update OCA icon logo #639
base: master
Are you sure you want to change the base?
Conversation
It was time to update the icon logo with the new branding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! 😄
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great !
@OCA/board |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That icon is not correct, as it doesn't reflect a module. Doing a proper one. Looking for the new OCA logo SVG. I will ask for it if not found.
@pedrobaeza what do you mean by "doesn't reflect the module"? I have a full folder of all OCA logo in SVG files that I can share with you, but please let me know what you mean. On my side I understood there are 2 topics about how a module is displayed on the Odoo App Store 2/ there is the possibility to fully display the goal of a module and it is shown as a big rectangle on the Odoo App Store, and this was discussed in another PR #639 (next step there is to have a generic image based on what Ivan asked Kapreon to do, and add this as a default image). I now see your suggestion with the new OCA logo in a box but I really don't see why there is this box. |
This image is for reflecting the module icon when there's no specific app/module icon. Odoo represents the lack of icon this way: So this icon should be a slightly similar one, but having the OCA logo inside. It's just an update of both parts of the icons: the OCA logo, and the new Odoo milk style of the "generic" icon module. |
Of course. But should we follow Odoo's convention ? IMHO, the proposed solution is sufficent by itself. |
hi again, I made a live survey with the people present in Brussels and in the general feedback is that the new logo without adding it in a box is better, but the letters OCA are missing. So here is the latest suggestion. @pedrobaeza Would it be acceptable to not use the box concept, even if Odoo does it like that? How could we proceed in such a situation with different opinions? Propose a voting survey for a few days and follow the majority? What's the usual process (I don't contribute on Github a lot so I am happy to follow the conventions)? |
The box is for consistency in the apps list and this gives also a distinction from a simple logo drop without more effort. Look how it's seen the different proposals in the module list: I'm adding another proposal with the box: Look also how it's seen in the detail page: against the simple logo one: I think we can make a larger survey, as this will impact in every new OCA module proposed (and it can even replace the old one if we detect it doing the migration to 17/18). |
@vdewulf @pedrobaeza A poll should be great indeed |
@vdewulf we don't have a regular process for this. The poll, as suggested by Dennis, may be OK, but you can use any tool you like, as GitHub doesn't have any tool for this. |
If we are going for a poll it should be done now. Otherwise it will take another year to have this merged. |
I made the poll directly in Github https://github.com/orgs/OCA/discussions/200 |
Oh, I didn't know that option of GH! |
Thanks @etobella ! |
The borders are taken from the regular Odoo missing module icon: https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/static/description/icon.svg and I'm preserving them for consistency. |
As commented here: https://github.com/orgs/OCA/discussions/200#discussioncomment-12040705, for dark mode, if plain logo is chosen, there should be an outer light frame or similar for improving the contrast and visibility of the icon. |
…imit for better contrast
@pedrobaeza folliowing the discussion and approval for the plain logo concept (https://github.com/orgs/OCA/discussions/200) I made a new proposal. |
for information, I asked Stéphane Bidoul to help about why is the CI red. |
who of course won't be upset if someone else has an idea about that problem :) |
It was time to update the icon logo with the new branding.