Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] update OCA icon logo #639

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[IMP] update OCA icon logo #639

wants to merge 2 commits into from

Conversation

vdewulf
Copy link

@vdewulf vdewulf commented Jan 31, 2025

It was time to update the icon logo with the new branding.

It was time to update the icon logo with the new branding.
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! 😄

LGTM

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@rousseldenis
Copy link
Contributor

@OCA/board

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That icon is not correct, as it doesn't reflect a module. Doing a proper one. Looking for the new OCA logo SVG. I will ask for it if not found.

@pedrobaeza
Copy link
Member

It would be like the following:

icon

But please pass me the OCA logo in SVG for having one without quality loss.

@vdewulf
Copy link
Author

vdewulf commented Jan 31, 2025

@pedrobaeza what do you mean by "doesn't reflect the module"? I have a full folder of all OCA logo in SVG files that I can share with you, but please let me know what you mean.

On my side I understood there are 2 topics about how a module is displayed on the Odoo App Store
1/ there is a simple icon, that is shown on the upper corner of the Odoo app store
This is the old oca logo in a (ugly) box.
That's what I try to update in this PR.

Sélection_356

2/ there is the possibility to fully display the goal of a module and it is shown as a big rectangle on the Odoo App Store, and this was discussed in another PR #639 (next step there is to have a generic image based on what Ivan asked Kapreon to do, and add this as a default image).

I now see your suggestion with the new OCA logo in a box but I really don't see why there is this box.
I'll send you the SVG files we have.

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 31, 2025

This image is for reflecting the module icon when there's no specific app/module icon. Odoo represents the lack of icon this way:

imagen

So this icon should be a slightly similar one, but having the OCA logo inside. It's just an update of both parts of the icons: the OCA logo, and the new Odoo milk style of the "generic" icon module.

@rousseldenis
Copy link
Contributor

This image is for reflecting the module icon when there's no specific app/module icon. Odoo represents the lack of icon this way:

Of course. But should we follow Odoo's convention ? IMHO, the proposed solution is sufficent by itself.

@pedrobaeza
Copy link
Member

Here you have the icons in both SVG and PNG:

icon
icon

I think it's important to have consistency for showing it in the module list, but having the specific brand.

@vdewulf
Copy link
Author

vdewulf commented Jan 31, 2025

hi again,

I made a live survey with the people present in Brussels and in the general feedback is that the new logo without adding it in a box is better, but the letters OCA are missing.

So here is the latest suggestion.

OCA_light_darkbackground_centered_bigger-128px

@pedrobaeza Would it be acceptable to not use the box concept, even if Odoo does it like that?

How could we proceed in such a situation with different opinions? Propose a voting survey for a few days and follow the majority?

What's the usual process (I don't contribute on Github a lot so I am happy to follow the conventions)?

@pedrobaeza
Copy link
Member

pedrobaeza commented Jan 31, 2025

The box is for consistency in the apps list and this gives also a distinction from a simple logo drop without more effort. Look how it's seen the different proposals in the module list:

imagen

I'm adding another proposal with the box:

imagen

Look also how it's seen in the detail page:

imagen

against the simple logo one:

imagen

I think we can make a larger survey, as this will impact in every new OCA module proposed (and it can even replace the old one if we detect it doing the migration to 17/18).

@rousseldenis
Copy link
Contributor

@vdewulf @pedrobaeza A poll should be great indeed

@pedrobaeza
Copy link
Member

@vdewulf we don't have a regular process for this. The poll, as suggested by Dennis, may be OK, but you can use any tool you like, as GitHub doesn't have any tool for this.

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Feb 3, 2025

@vdewulf @pedrobaeza A poll should be great indeed

If we are going for a poll it should be done now. Otherwise it will take another year to have this merged.
So let's have a deadline this Wednesday 09:00. If until Wednesday there is no result, @vdewulf will take the final decision and this will be merged Wednesday 12:00.

@etobella
Copy link
Member

etobella commented Feb 3, 2025

I made the poll directly in Github https://github.com/orgs/OCA/discussions/200

@pedrobaeza
Copy link
Member

Oh, I didn't know that option of GH!

@vdewulf
Copy link
Author

vdewulf commented Feb 3, 2025

Thanks @etobella !
I'll share this poll on the contributors mailing list with the Deadline of Wednesday 9am CET.

@LoisRForgeFlow
Copy link

I'm adding another proposal with the box:

imagen

The problem I see with this one are the borders of the cube, couldn't you just make them with the same blue as the background of the faces of the cube? or something more similar at least if some contrast is needed to make it clear it is a cube.

@pedrobaeza
Copy link
Member

pedrobaeza commented Feb 3, 2025

The problem I see with this one are the borders of the cube, couldn't you just make them with the same blue as the background of the faces of the cube? or something more similar at least if some contrast is needed to make it clear it is a cube.

The borders are taken from the regular Odoo missing module icon:

https://github.com/odoo/odoo/blob/18.0/odoo/addons/base/static/description/icon.svg

and I'm preserving them for consistency.

@pedrobaeza
Copy link
Member

This is a test without that borders:

icon4

@pedrobaeza
Copy link
Member

As commented here: https://github.com/orgs/OCA/discussions/200#discussioncomment-12040705, for dark mode, if plain logo is chosen, there should be an outer light frame or similar for improving the contrast and visibility of the icon.

@etobella etobella requested a review from pedrobaeza February 7, 2025 13:59
@vdewulf
Copy link
Author

vdewulf commented Feb 7, 2025

@pedrobaeza folliowing the discussion and approval for the plain logo concept (https://github.com/orgs/OCA/discussions/200) I made a new proposal.
Could you review it please?
Thanks!

@vdewulf
Copy link
Author

vdewulf commented Feb 7, 2025

for information, I asked Stéphane Bidoul to help about why is the CI red.

@sbidoul
Copy link
Member

sbidoul commented Feb 7, 2025

for information, I asked Stéphane Bidoul to help about why is the CI red.

who of course won't be upset if someone else has an idea about that problem :)

@ivs-cetmix
Copy link
Member

image

wow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants