[17.0][MIG] maintenance_equipment_sequence #399

Anxo82 · 2024-06-03T09:43:43Z

Standard migration

…ch view

Currently translated at 100.0% (10 of 10 strings) Translation: maintenance-11.0/maintenance-11.0-maintenance_equipment_sequence Translate-URL: https://translation.odoo-community.org/projects/maintenance-11-0/maintenance-11-0-maintenance_equipment_sequence/es/

Currently translated at 100.0% (10 of 10 strings) Translation: maintenance-13.0/maintenance-13.0-maintenance_equipment_sequence Translate-URL: https://translation.odoo-community.org/projects/maintenance-13-0/maintenance-13-0-maintenance_equipment_sequence/it/

Currently translated at 100.0% (10 of 10 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_sequence Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_sequence/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-16.0/maintenance-16.0-maintenance_equipment_sequence Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_equipment_sequence/

dalonsod

@Anxo82 see comment, and also, please add sequence_prefix to category tree and search view in a separate commit, if possible.

dalonsod · 2024-06-16T11:46:31Z

maintenance_equipment_sequence/tests/test_maintenance_equipment_sequence.py

+        cat_01._compute_equipment_code()
+
+        self.assertEqual(equipment_01.serial_no, "TST001")
+        self.assertEqual(equipment_02.serial_no, "TST002")


Test improvement suggestion:

Suggested change

cat_01._compute_equipment_code()

self.assertEqual(equipment_01.serial_no, "TST001")

self.assertEqual(equipment_02.serial_no, "TST002")

equipment_03 = self.env["maintenance.equipment"].create(

{

"name": "Test Equipment 3",

"category_id": False,

"serial_no": False,

}

)

self.assertEqual(equipment_01.serial_no, "TST001")

self.assertEqual(equipment_02.serial_no, "TST002")

self.assertFalse(equipment_03.serial_no)

equipment_03.write({"category_id": cat_01.id})

self.assertEqual(equipment_03.serial_no, "TST003")

_compute_equipment_code() isn't needed to be directly called because create() and write() actually call it. With third equipment case test pending uncovered line will be covered, if I'm not wrong.

Anxo82 · 2024-06-17T06:53:39Z

@dalonsod could you review please.
Thanks

dalonsod

See latest comment, not blocking, I've approved it anyway

dalonsod · 2024-06-17T06:57:20Z

maintenance_equipment_sequence/views/maintenance_views.xml

+        <field name="inherit_id" ref="maintenance.hr_equipment_category_view_tree" />
+        <field name="arch" type="xml">
+            <field name="company_id" position="after">
+                <field name="sequence_prefix" />


I'd only make a little extra change: making new tree field optional:

Suggested change

<field name="sequence_prefix" />

<field name="sequence_prefix" optional="show" />

…ws tree and search

Anxo82 · 2024-06-17T07:19:19Z

@AdriaGForgeFlow, @NuriaXifre could you review please?
Thanks.

peluko00

Please, squash migration commits into one, LGTM

OCA-git-bot · 2024-06-19T09:31:30Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dalonsod · 2024-06-19T10:32:01Z

Please, squash migration commits into one, LGTM

Hello @peluko00 if you are referring to the two latest commits, keeping them separated makes possible porting added functionality to previous Odoo versions, if needed

JulienMartinez

test on the runboat
LGTM

dalonsod · 2024-08-12T06:53:32Z

Hello @etobella could you merge this PR? Thanks!

dalonsod · 2024-08-20T06:46:14Z

Hello @gurneyalex could you merge this PR? Thanks!

etobella · 2024-08-20T07:29:44Z

/ocabot merge nobump

OCA-git-bot · 2024-08-20T07:29:53Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-399-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2024-08-20T07:34:09Z

Congratulations, your PR was merged at ae9cf00. Thanks a lot for contributing to OCA. ❤️

AdriaGForgeFlow and others added 26 commits May 31, 2024 12:08

[11.0][ADD] maintenance_equipment_sequence

8604dc8

fix sequence step

500fed3

Code always displayed as "Code" to avoid confusion and add it to sear…

7330262

…ch view

fixup and increase test coverage

09e0680

Added translation using Weblate (Spanish)

5ffe7d5

[12.0][MIG]maintenance_equipment_sequence

b98f602

[FIX] maintenance_equipment_sequence write

318e15c

[IMP] maintenance_equipment_sequence: black, isort

c8659bb

[13.0][MIG] maintenance_equipment_sequence

97ba51d

Added translation using Weblate (Italian)

f77988b

[IMP] maintenance_equipment_sequence: black, isort, prettier

076c538

[MIG] maintenance_equipment_sequence: Migration to 14.0

0a98d96

[IMP] maintenance_equipment_sequence: black, isort, prettier

48046b1

[MIG] maintenance_equipment_sequence: Migration to 15.0

dcd1324

[UPD] Update maintenance_equipment_sequence.pot

0fb12fb

[UPD] README.rst

068ac3b

[15.0][FIX] maintenance_equipment_sequence: Add Readme migrations folder

8ee1859

maintenance_equipment_sequence 15.0.1.0.1

42233dc

[MIG] maintenance_equipment_sequence: Migration to 16.0

19047a5

[UPD] Update maintenance_equipment_sequence.pot

bea5b09

[UPD] README.rst

35d7e11

[IMP] maintenance_equipment_sequence: pre-commit auto fixes

90f7a5e

Anxo82 force-pushed the 17.0-mig-maintenance_equipment_sequence branch 4 times, most recently from c205b1d to f636a75 Compare June 4, 2024 12:57

Anxo82 force-pushed the 17.0-mig-maintenance_equipment_sequence branch from f636a75 to 42597b4 Compare June 5, 2024 11:19

dalonsod suggested changes Jun 16, 2024

View reviewed changes

[MIG] maintenance_equipment_sequence: Migration to 17.0

d31c7dd

Anxo82 force-pushed the 17.0-mig-maintenance_equipment_sequence branch 2 times, most recently from b5aabde to a2b0350 Compare June 17, 2024 06:50

dalonsod approved these changes Jun 17, 2024

View reviewed changes

[IMP] maintenance_equipment_sequence: Add field sequece_prefix to vie…

ba7e914

…ws tree and search

Anxo82 force-pushed the 17.0-mig-maintenance_equipment_sequence branch from a2b0350 to ba7e914 Compare June 17, 2024 07:05

dalonsod mentioned this pull request Jun 18, 2024

[17.0][MIG] maintenance_equipment_sequence: Migration to 17.0 #409

Closed

peluko00 approved these changes Jun 19, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jun 19, 2024

JulienMartinez approved these changes Aug 7, 2024

View reviewed changes

etobella approved these changes Aug 20, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Aug 20, 2024

OCA-git-bot merged commit 8094093 into OCA:17.0 Aug 20, 2024
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Aug 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] maintenance_equipment_sequence #399

[17.0][MIG] maintenance_equipment_sequence #399

Anxo82 commented Jun 3, 2024

dalonsod left a comment

dalonsod Jun 16, 2024

Anxo82 commented Jun 17, 2024

dalonsod left a comment

dalonsod Jun 17, 2024

Anxo82 commented Jun 17, 2024

peluko00 left a comment

OCA-git-bot commented Jun 19, 2024

dalonsod commented Jun 19, 2024

JulienMartinez left a comment

dalonsod commented Aug 12, 2024

dalonsod commented Aug 20, 2024

etobella commented Aug 20, 2024

OCA-git-bot commented Aug 20, 2024

OCA-git-bot commented Aug 20, 2024

-        cat_01._compute_equipment_code()
-        self.assertEqual(equipment_01.serial_no, "TST001")
-        self.assertEqual(equipment_02.serial_no, "TST002")
+        equipment_03 = self.env["maintenance.equipment"].create(
+            {
+                "name": "Test Equipment 3",
+                "category_id": False,
+                "serial_no": False,
+            }
+        )
+        self.assertEqual(equipment_01.serial_no, "TST001")
+        self.assertEqual(equipment_02.serial_no, "TST002")
+        self.assertFalse(equipment_03.serial_no)
+        equipment_03.write({"category_id": cat_01.id})
+        self.assertEqual(equipment_03.serial_no, "TST003")

	<field name="sequence_prefix" />
	<field name="sequence_prefix" optional="show" />

[17.0][MIG] maintenance_equipment_sequence #399

[17.0][MIG] maintenance_equipment_sequence #399

Conversation

Anxo82 commented Jun 3, 2024

dalonsod left a comment

Choose a reason for hiding this comment

dalonsod Jun 16, 2024

Choose a reason for hiding this comment

Anxo82 commented Jun 17, 2024

dalonsod left a comment

Choose a reason for hiding this comment

dalonsod Jun 17, 2024

Choose a reason for hiding this comment

Anxo82 commented Jun 17, 2024

peluko00 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 19, 2024

dalonsod commented Jun 19, 2024

JulienMartinez left a comment

Choose a reason for hiding this comment

dalonsod commented Aug 12, 2024

dalonsod commented Aug 20, 2024

etobella commented Aug 20, 2024

OCA-git-bot commented Aug 20, 2024

OCA-git-bot commented Aug 20, 2024