[17.0][MIG] maintenance_project #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anxo82
force-pushed
the
17.0-mig-maintenance_project
branch
from
984a190
to
5f49cfb
Compare
dalonsod
reviewed
Jun 26, 2024
| @@ -0,0 +1 @@ | |||
| odoo-addon-base_maintenance @ git+https://github.com/OCA/maintenance.git@refs/pull/400/head#subdirectory=base_maintenance | |||
There was a problem hiding this comment.
@Anxo82 test requirements file seems to be good, but it should be placed in the root folder, not inside addon directory.
Anxo82
force-pushed
the
17.0-mig-maintenance_project
branch
from
5f49cfb
to
b05094e
Compare
Anxo82
force-pushed
the
17.0-mig-maintenance_project
branch
2 times, most recently
from
a674900
to
4cf3b01
Compare
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-14.0/maintenance-14.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_project/
Currently translated at 100.0% (23 of 23 strings) Translation: maintenance-14.0/maintenance-14.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-14-0/maintenance-14-0-maintenance_project/it/
Currently translated at 100.0% (23 of 23 strings) Translation: maintenance-15.0/maintenance-15.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-15-0/maintenance-15-0-maintenance_project/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/es/
Currently translated at 100.0% (21 of 21 strings) Translation: maintenance-16.0/maintenance-16.0-maintenance_project Translate-URL: https://translation.odoo-community.org/projects/maintenance-16-0/maintenance-16-0-maintenance_project/it/
dalonsod
force-pushed
the
17.0-mig-maintenance_project
branch
from
4cf3b01
to
f132c76
Compare
|
@FernandoRomera tests fixed, could you review? |
FernandoRomera
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
@dalonsod
LGTM.
A silly thing, to follow OCA guidelines. Rename dir data to demo
dalonsod
force-pushed
the
17.0-mig-maintenance_project
branch
from
f132c76
to
7d86d06
Compare
|
@mymage could you review? Thanks! |
@FernandoRomera done! |
mymage
approved these changes
Aug 19, 2024
|
This PR has the |
dalonsod
reviewed
Aug 19, 2024
| <field name="create_project_from_equipment" invisible="id" /> | ||
| <field | ||
| name="project_id" | ||
| invisible="create_project_from_equipment or not id" |
There was a problem hiding this comment.
@Anxo82 according to original code this condition's been translated wrong in new syntax, please check:
Suggested change
| invisible="create_project_from_equipment or not id" | |
| invisible="create_project_from_equipment and not id" |
Anxo82
force-pushed
the
17.0-mig-maintenance_project
branch
from
7d86d06
to
ed288fd
Compare
Co-Authored-By: David Alonso <david.alonso@solvos.es>
dalonsod
force-pushed
the
17.0-mig-maintenance_project
branch
from
ed288fd
to
533ba1b
Compare
|
@etobella could you review? Thanks! |
etobella
approved these changes
Aug 20, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
/ocabot migration maintenance_project |
|
Congratulations, your PR was merged at 21e6f4d. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove in demo_maintenance_project.xml 2 fields: "maintenance_duration" and "period". This fields removed in base odoo.