[14.0][IMP] Don't set picking to done automatically #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- serial number product combined with regular product - backorder created on serial number validation
|
Hi @aleuffre, @renda-dev, |
thomaspaulb
force-pushed
the
14.0-done-state
branch
from
9f2a7e3
to
bf28a58
Compare
By default picking state is forced to Done when SO picking is done, but if picking sync fails, eg if there is a mismatch in SO and PO move lines, user can't correct anything since the picking is already set to Done. This may be acceptable in cases where 100% of the syncs go OK but we make the setting configurable to support situations where manual corrections are needed.
thomaspaulb
force-pushed
the
14.0-done-state
branch
from
bf28a58
to
ba93779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code forces PO picking state to Done when SO picking is done, but this can be harmful:
If there was a mismatch in SO and PO move lines, activity is created for user to fix, but picking is already set to Done, then user can't correct anything
Revival of #642