Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD]pms: Self billing folios configuration #310

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

DarioLodeiros
Copy link
Member

@DarioLodeiros DarioLodeiros commented Jan 8, 2025

Enhancements to the billing process by adding support for self-billed journals and taxes. The changes ensure that the system correctly applies self-billed journals and taxes when the partner is the same as the company partner.

Key changes include:

Self-billing support:

  • Added self_billed_journal_id and self_billed_tax_ids fields to the ResCompany model to store the self-billed journal and taxes information.

Invoice and tax computation:

  • Updated _get_folio_default_journal method in pms_property.py to return the self-billed journal if the partner is the company partner.
  • Modified _compute_tax_ids method in pms_reservation.py to check for self-billed taxes when the partner is the company partner.
  • Enhanced _compute_tax_ids method in pms_service.py to apply self-billed taxes when the service partner is the company partner.

@DarioLodeiros DarioLodeiros force-pushed the 14.0-self_billing_folios branch from d7b748c to 9a4d542 Compare January 9, 2025 17:18
@DarioLodeiros
Copy link
Member Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-310-by-DarioLodeiros-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 14, 2025
Signed-off-by DarioLodeiros
@OCA-git-bot
Copy link
Contributor

@DarioLodeiros your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-310-by-DarioLodeiros-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@DarioLodeiros
Copy link
Member Author

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-310-by-DarioLodeiros-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 26, 2025
Signed-off-by DarioLodeiros
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-310-by-DarioLodeiros-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0a39c37 into OCA:14.0 Jan 26, 2025
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6bc2475. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants