[14.0][IMP] pos_no_cash_bank_statement: Filter payment methods configured in the POS. #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexis-via, |
chienandalu
approved these changes
May 31, 2023
chienandalu
approved these changes
Jun 5, 2023
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Does it need to be forward ported? |
|
Congratulations, your PR was merged at 74408c5. Thanks a lot for contributing to OCA. ❤️ |
|
Hi @chienandalu I don't know what you mean, this module is not migrated in later versions. As stated in the comment #849 (comment) it is not necessary to migrate it. |
|
Ok, that's what I meant 😄 Thanks for the heads up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of having several payment methods and several POS (not all of them were configured with all the payment methods), when closing the session, 1
account.bank.statementwas being created for each payment method even if it was not configured in the POS.With this PR, we filtered those payment methods configured in the POS.