Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] pos_reset_search #1030

Merged
merged 26 commits into from
Dec 19, 2023

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Aug 2, 2023

Currently not working. When searching and then clicking on a product, an error is raised :

TypeError: ProductScreenChildren[key].el is undefined
    _clickProduct@http://localhost:8012/web/assets/debug/point_of_sale.assets.js:45187:25 (/pos_reset_search/static/src/js/ProductScreen.js:13)
    __trigger@http://localhost:8012/web/assets/debug/web.assets_common.js:22576:21 (/web/static/src/legacy/legacy_component.js:89)
    trigger@http://localhost:8012/web/assets/debug/web.assets_common.js:22560:14 (/web/static/src/legacy/legacy_component.js:73)
    template/hdlr2<@http://localhost:8012/web/assets/debug/web.assets_common.js line 21902 > Function:14:25 (/web/static/lib/owl/owl.js:5508)
    mainEventHandler@http://localhost:8012/web/assets/debug/web.assets_common.js:22169:25 (/web/static/lib/owl/owl.js:5775)
    listener@http://localhost:8012/web/assets/debug/web.assets_common.js:16792:20 (/web/static/lib/owl/owl.js:398)

So far, I don't understand the problem. Help would be very welcomed :)

@legalsylvain
Copy link
Contributor

/ocabot migration pos_reset_search

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 26, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 26, 2023
37 tasks
Co-Authored-By: Carmen Bianca BAKKER <carmen@coopiteasy.be>
@carmenbianca
Copy link
Member

@victor-champonnois I fixed this PR for ya.

@robinkeunen
Copy link

@victor-champonnois Can you undraft this PR ?
@legalsylvain this is waiting a Christmas review 🥳

@victor-champonnois victor-champonnois marked this pull request as ready for review December 19, 2023 17:01
@chienandalu
Copy link
Member

🎅

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1030-by-chienandalu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 22b8663 into OCA:16.0 Dec 19, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b26c7a2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.