Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] pos_partner_birthdate: partner birthdate field wasn't being saved from PoS #1031

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[16.0][FIX] pos_partner_birthdate: partner birthdate field wasn't being saved from PoS #1031

merged 2 commits into from
Aug 23, 2023

Conversation

suker
Copy link
Contributor

@suker suker commented Aug 2, 2023

Steps to reproduce:

  1. Install module and open a pos session
  2. Select a customer and edit its birthdate field
  3. Check that birthdate field has not been saved on frontend/backend

@OCA-git-bot
Copy link
Contributor

Hi @ecino,
some modules you are maintaining are being modified, check this out!

@suker
Copy link
Contributor Author

suker commented Aug 2, 2023

It seems that in this change odoo/odoo@c585d82 they made partner editor screen reactivity changing its logic.

ecino
ecino approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, code LGTM, didn't tested it yet. 👍

@suker suker mentioned this pull request Aug 3, 2023
Merged
@suker
Copy link
Contributor Author

suker commented Aug 4, 2023

Testing functionality I found a bug on partner creation in a pos session when birthdate field is empty, its already fixed in this commit

image

@suker
Copy link
Contributor Author

suker commented Aug 18, 2023

@ecino can you take a look please?

ecino
ecino approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@suker
Copy link
Contributor Author

suker commented Aug 23, 2023

@OCA/pos-maintainers changes approved, can you merge it?

chienandalu
chienandalu approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1031-by-chienandalu-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit fc1bd2c into OCA:16.0 Aug 23, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9192300. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecino ecino ecino approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suker @OCA-git-bot @chienandalu @ecino