Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] pos_order_remove_line: Trigger #1044

Merged
merged 1 commit into from
Aug 31, 2023
Merged

[16.0][FIX] pos_order_remove_line: Trigger #1044

merged 1 commit into from
Aug 31, 2023

Conversation

papulo79
Copy link

Function logic is modified in order to use the numpad backspace trigger.

Uses _updateSelectedOrderline() method and works with any module installed and their extended methods, like pos_loyalty, executing all inherited functions and fixing the problem that doesn't recalculates loyalty points when pos_loyalty is installed and removes an order line.

@OCA-git-bot
Copy link
Contributor

Hi @robyf70,
some modules you are maintaining are being modified, check this out!

@papulo79 papulo79 force-pushed the 16.0-pos_order_remove_line_trigger branch from ca4d380 to b5244e9 Compare August 17, 2023 11:33
robyf70
robyf70 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@papulo79 papulo79 changed the title [FIX] pos_order_remove_line: Trigger [16.0][FIX] pos_order_remove_line: Trigger Aug 18, 2023
@papulo79 papulo79 marked this pull request as ready for review August 18, 2023 07:11
@flachica
Copy link
Contributor

With pos_restaurant installed and removing last line

TypeError: Cannot read properties of undefined (reading 'id')
    at Orderline.selectLine (:8069/web/assets/debug/point_of_sale.assets.js:47046:64) (/pos_restaurant/static/src/js/Screens/ProductScreen/Orderline.js:29)
    at Object.mainEventHandler (:8069/web/assets/debug/web.assets_common.js:22200:25) (/web/static/lib/owl/owl.js:5806)
    at HTMLLIElement.listener (:8069/web/assets/debug/web.assets_common.js:16817:20) (/web/static/lib/owl/owl.js:423)

[16.0][FIX] pos_order_remove_line: Trigger
83b5976 
- Function logic is modified in order to use the numpad backspace trigger.
- Stops event propagation and prevents default actions.
@papulo79 papulo79 force-pushed the 16.0-pos_order_remove_line_trigger branch from f61de12 to 83b5976 Compare August 24, 2023 09:07
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@robyf70
Copy link
Contributor

robyf70 commented Aug 31, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1044-by-robyf70-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6b19128 into OCA:16.0 Aug 31, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 50650c0. Thanks a lot for contributing to OCA. ❤️

@papulo79 papulo79 deleted the 16.0-pos_order_remove_line_trigger branch September 26, 2023 07:23
@danielduqma danielduqma mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyf70 robyf70 robyf70 approved these changes

@flachica flachica flachica approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@papulo79 @OCA-git-bot @flachica @robyf70