[ADD] pos_stock_available_online: Add new module #922

GabbasovDinar · 2023-01-25T16:32:03Z

Show the available quantity of products in the Point of Sale

ivs-cetmix

Functional is ok. Need to add a note regarding same company warehouses though.

hugho-ad · 2023-02-10T00:04:43Z

pos_stock_available_online/models/pos_session.py

+
+    def _process_pos_ui_product_product(self, products):
+        config = self.config_id
+        if config.display_product_quantity:


return early and save a identation level

Suggested change

if config.display_product_quantity:

if not config.display_product_quantity:

return super()._process_pos_ui_product_product(products)

Hello, @hugho-ad the negative condition is more difficult to read code I see no reason to change in this way

not it's not, is called early return pattern
https://medium.com/swlh/return-early-pattern-3d18a41bba8

@hugho-ad we have to return "super" in any case. In your case, you offer to return only if this setting is not specified, which is not true.

hugho-ad · 2023-02-10T00:09:06Z

pos_stock_available_online/models/res_config_settings.py

+class ResConfigSettings(models.TransientModel):
+    _inherit = "res.config.settings"
+
+    pos_display_product_quantity = fields.Boolean(


res.configs.settings are per company

this fields should be on pos.config form view instead

starting with Odoo 16 all settings specific to POS are defined in this model, you can check the original Odoo code. https://github.com/odoo/odoo/blob/b0df10c1e497f65b891f7141055e7f339d11b4b1/addons/point_of_sale/models/res_config_settings.py#L48-L105

awesome, I didn't know that

thanks!

hugho-ad · 2023-02-10T00:15:47Z

pos_stock_available_online/models/stock_quant.py

+                    ("config_id.display_product_quantity", "=", True),
+                    "|",
+                    ("config_id.additional_warehouse_ids", "in", [warehouse_id]),
+                    ("config_id.main_warehouse_id", "=", warehouse_id),


also quant.product in producs inside categories setup on the pos.config?

hugho-ad · 2023-02-10T00:17:06Z

pos_stock_available_online/models/stock_quant.py

+                    ("config_id.main_warehouse_id", "=", warehouse_id),
+                ],
+            ).mapped("config_id")
+            if configs:


you got a for loop inside the _notify_available_quantity, if not record on the set, then will not perform any

Suggested change

if configs:

configs._notify_available_quantity(quant._prepare_pos_message())

this check is added to prevent the _prepare_pos_message method for the current quant from triggering unnecessarily if no config is found.

hugho-ad · 2023-02-10T00:19:34Z

pos_stock_available_online/static/src/js/Screens/ProductScreen/ProductItem.esm.js

+        format_quantity(quantity) {
+            const unit = this.env.pos.units_by_id[this.props.product.uom_id[0]];
+            var formattedQuantity = `${quantity}`;
+            if (unit) {


Suggested change

if (unit) {

if (!unit) return `${formattedQuantity}`;

We should use no-negative condition: https://eslint.org/docs/latest/rules/no-negated-condition

nice! there is a eslint about that!

hugho-ad · 2023-02-10T00:21:02Z

pos_stock_available_online/static/src/js/Screens/ProductScreen/ProductsWidget.esm.js

+            const ProductIds = [];
+            for (const payload of payloads) {
+                for (const message of payload) {
+                    var product = db.get_product_by_id(message.product_id);


you could avoid this if you sent from backend only notifications used on the pos.config

If a new product is added to the POS, this product will not be available in the POS until the POS product is read again (for example, until the page is updated), this check is necessary so that the POS does not process information about the product that is available in the POS but not actually displayed (because the pos db is not yet updated)

hugho-ad · 2023-02-10T00:22:24Z

pos_stock_available_online/static/src/js/Screens/ProductScreen/ProductItem.esm.js

@@ -0,0 +1,43 @@
+/** @odoo-module **/


use
odoo.define'module.class', function (require) {

also rename the fiele
Productitem.esm.js > Productitem_esm.js

I see no reason to use the old approach of defining modules when there is OWL and the new approach, which also will not create problems in porting

Why? the file with this extension will be picked up by the OCA .eslint rule for ESM modules.:
see https://github.com/OCA/pos/blob/16.0/.eslintrc.yml#L11
and [16.0] [MIG] pos_order_remove_line: migration to 16.0 #925 (comment)

@GabbasovDinar thanks man, I need and update with v16.0

hugho-ad · 2023-02-10T00:25:09Z

Hello @GabbasovDinar

thanks for the contribution! awsome!

how can we help you with the latest changes?

PhilDL · 2023-02-16T13:01:11Z

Thanks for the contribution, the code looks okay to me, but I have some doubts about the UX, it looks very cluttered
with 2 warehouses:

Actual

Proposal

This is a suggestion of UX changes I tried, changing a few things. Feel free to follow it or not, depending on general feedback. It would look like that:

Changes made:

Use the Warehouse code instead of the name to gain some space:

class StockWarehouse(models.Model):
    _inherit = "stock.warehouse"

    def _prepare_vals_for_pos(self, product):
        """
        Prepare warehouse info data to send a POS
        """
        self.ensure_one()
        return {
            "id": self.id,
            "name": self.name,
            "code": self.code,
            "quantity": product.with_context(warehouse=self.id).immediately_usable_qty,
            "product_id": product.id,
        }

I changed the view with:

XPath inside "product-content"
Changed the order of the elements
added font-awesome icon, also used the code instead of the warehouse name:

<t
        t-name="ProductItem"
        t-inherit="point_of_sale.ProductItem"
        t-inherit-mode="extension"
        owl="1"
    >
        <xpath expr="//div[hasclass('product-content')]" position="inside">
            <div t-if="env.pos.config.display_product_quantity" class="warehouse-info">
                <div class="flex">
                    <div t-if="warehouses.length > 1" class="warehouse total" title="Total">
                        <i class="fa fa-dropbox"/>
                        <span
                            t-attf-class="quantity {{total_quantity > env.pos.config.minimum_product_quantity_alert ? 'available' : 'not-available'}}"
                        >
                            <t t-esc="display_total_quantity" />
                        </span>
                    </div>
                </div>
                <div class="flex">
                    <t t-foreach="warehouses" t-as="warehouse" t-key="warehouse.id">
                        <div class="warehouse" t-att-title="warehouse.name">
                            <span class="warehouse-name">
                                <t t-esc="warehouse.code" />
                            </span>
                            <span
                                t-attf-class="quantity {{warehouse.quantity > env.pos.config.minimum_product_quantity_alert ? 'available' : 'not-available'}}"
                            >
                                <t t-esc="format_quantity(warehouse.quantity)" />
                            </span>
                        </div>
                    </t>
                </div>
            </div>
        </xpath>
    </t>

Removed the absolute positioning and made use of flex to display elements in a more compact way:

.pos .product-list .warehouse-info {
    padding: 0 6px;
    font-weight: bold;
    display: flex;
    border-top: 1px solid #efefef;
    justify-content: space-between;
}
.pos .product-list .warehouse-info .warehouse {
    display: flex;
    flex-direction: row;
    justify-content: space-between;
    align-items: center;
}
.pos .product-list .warehouse-info .warehouse .quantity {
    color: black;
    padding: 1px 2px;
    font-size: 11px;
}
.pos .product-list .warehouse-info .warehouse .warehouse-name {
    display: block;
    color: #696969;
    font-size: 10px;
}
.pos .product-list .warehouse-info .warehouse.total .warehouse-name {
    font-weight: bold;
}
.pos .product-list .warehouse-info .warehouse .quantity.available {
    color: #32a868;
}
.pos .product-list .warehouse-info .warehouse .quantity.not-available {
    color: #ef5350;
}

GabbasovDinar · 2023-02-23T09:10:24Z

@PhilDL Thanks for your suggestions, I applied these changes and it looks much better now

hugho-ad · 2023-03-01T22:58:31Z

@ivantodorovich

what do you think?

ready to merge?

…lability with POS [FIX] fixed pre-commit errors

OCA-git-bot · 2023-03-06T15:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix · 2023-03-06T15:11:16Z

@OCA/pos-maintainers could you please have a look into this PR?

gregory-moka · 2023-03-14T16:26:26Z

Why don't you use the Info tab ? You can display what you want without overloading the POS view.

Thanks for the contribution, the code looks okay to me, but I have some doubts about the UX, it looks very cluttered with 2 warehouses:

Actual

Proposal

This is a suggestion of UX changes I tried, changing a few things. Feel free to follow it or not, depending on general feedback. It would look like that:

ivs-cetmix · 2023-03-14T19:54:00Z

Why don't you use the Info tab ? You can display what you want without overloading the POS view.

Which info tab do you mean? Could you please provide some picture?

liebana · 2023-03-16T12:08:07Z

I don't know if I'm missing something, but this is something already featured in: https://github.com/OCA/pos/tree/16.0/pos_product_quick_info

(I think that's what @gregory-moka meant @isserver1 )

ivs-cetmix · 2023-03-16T22:44:28Z

I don't know if I'm missing something, but this is something already featured in: https://github.com/OCA/pos/tree/16.0/pos_product_quick_info

(I think that's what @gregory-moka meant @isserver1 )

Yup. This is also our module that we have contributed earlier. However the current one has completely different approach.
Just imagine if you need to have a quick overlook at your current stock. Clicking each product to check quantity available might take tons of time. And here you can easily see which products are available right now without doing any clicks.
Meanwhile this module was originally developed for Odoo 13 and our customer has been happily using it for 2 years already.
So we agreed to open source it for Odoo 16 and share with the community.

ivantodorovich · 2023-03-27T13:25:25Z

/ocabot merge nobump

OCA-git-bot · 2023-03-27T13:25:34Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-922-by-ivantodorovich-bump-nobump, awaiting test results.

Signed-off-by ivantodorovich

OCA-git-bot · 2023-03-27T13:35:39Z

Congratulations, your PR was merged at 55e2ef9. Thanks a lot for contributing to OCA. ❤️

GabbasovDinar force-pushed the 16.0-pos_stock_available_realtime branch from b43575a to 942fcd6 Compare January 25, 2023 19:10

GabbasovDinar changed the title ~~[ADD] pos_stock_available_realtime: Add new module~~ [ADD] pos_stock_available_online: Add new module Jan 25, 2023

GabbasovDinar force-pushed the 16.0-pos_stock_available_realtime branch 5 times, most recently from deb2f4b to f5f3cca Compare February 1, 2023 18:25

ivs-cetmix force-pushed the 16.0-pos_stock_available_realtime branch from f5f3cca to 5a6ecf0 Compare February 1, 2023 18:56

GabbasovDinar marked this pull request as ready for review February 2, 2023 20:05

GabbasovDinar force-pushed the 16.0-pos_stock_available_realtime branch from 5a6ecf0 to 8ba138a Compare February 3, 2023 18:46

ivs-cetmix approved these changes Feb 3, 2023

View reviewed changes

hugho-ad suggested changes Feb 10, 2023

View reviewed changes

GabbasovDinar force-pushed the 16.0-pos_stock_available_realtime branch from 8ba138a to 7dc740d Compare February 23, 2023 09:07

PhilDL approved these changes Feb 24, 2023

View reviewed changes

hugho-ad approved these changes Mar 1, 2023

View reviewed changes

OCA-git-bot added the approved label Mar 1, 2023

ivs-cetmix force-pushed the 16.0-pos_stock_available_realtime branch from d6f6551 to cb3fdf5 Compare March 2, 2023 17:38

GabbasovDinar force-pushed the 16.0-pos_stock_available_realtime branch 2 times, most recently from 80fd992 to 5ed44b8 Compare March 2, 2023 20:02

[ADD] pos_stock_available_online: Add new module to sync product avai…

f3be4c0

…lability with POS [FIX] fixed pre-commit errors

ivs-cetmix force-pushed the 16.0-pos_stock_available_realtime branch from 5ed44b8 to f3be4c0 Compare March 2, 2023 20:26

OCA-git-bot added the ready to merge label Mar 6, 2023

legalsylvain added this to the 16.0 milestone Mar 13, 2023

OCA-git-bot added the bot is merging ⏳ label Mar 27, 2023

OCA-git-bot added a commit that referenced this pull request Mar 27, 2023

Merge PR #922 into 16.0

a1b315d

Signed-off-by ivantodorovich

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 27, 2023

OCA-git-bot closed this Mar 27, 2023

GabbasovDinar deleted the 16.0-pos_stock_available_realtime branch March 28, 2023 06:20

	if config.display_product_quantity:
	if not config.display_product_quantity:
	return super()._process_pos_ui_product_product(products)

	if configs:
	configs._notify_available_quantity(quant._prepare_pos_message())

[ADD] pos_stock_available_online: Add new module #922

[ADD] pos_stock_available_online: Add new module #922

Conversation

GabbasovDinar commented Jan 25, 2023 • edited Loading

ivs-cetmix left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hugho-ad commented Feb 10, 2023

PhilDL commented Feb 16, 2023 • edited Loading

Actual

Proposal

Changes made:

GabbasovDinar commented Feb 23, 2023

hugho-ad commented Mar 1, 2023

OCA-git-bot commented Mar 6, 2023

ivs-cetmix commented Mar 6, 2023

gregory-moka commented Mar 14, 2023

Actual

Proposal

ivs-cetmix commented Mar 14, 2023

liebana commented Mar 16, 2023

ivs-cetmix commented Mar 16, 2023

ivantodorovich commented Mar 27, 2023

OCA-git-bot commented Mar 27, 2023

OCA-git-bot commented Mar 27, 2023

GabbasovDinar commented Jan 25, 2023 •

edited

Loading

PhilDL commented Feb 16, 2023 •

edited

Loading