Merge pull request #10 from vauxoo-dev/master-oca-deprecated-tag-openerp

[ADD] Add check 'deprecated-openerp-xml-node'
OCA · Nov 2, 2015 · d11d7a3 · d11d7a3
2 parents ae8955a + ebc8d56
commit d11d7a3
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/pylint_odoo/checkers/modules_odoo.py b/pylint_odoo/checkers/modules_odoo.py
@@ -43,13 +43,17 @@
         'javascript-lint',
         settings.DESC_DFLT
     ),
+    'W%d04' % settings.BASE_OMODULE_ID: (
+        '%s:%d Deprecated <openerp> xml node',
+        'deprecated-openerp-xml-node',
+        settings.DESC_DFLT
+    ),
     'W%d05' % settings.BASE_OMODULE_ID: (
         '%s:%d record res.users without '
         'context="{\'no_reset_password\': True}"',
         'create-user-wo-reset-password',
         settings.DESC_DFLT
     ),
-
 }
 
 
@@ -192,3 +196,22 @@ def _check_javascript_lint(self):
         if self.msg_args:
             return False
         return True
+
+    def _check_deprecated_openerp_xml_node(self):
+        '''Check deprecated <openerp> xml node
+        :return: False if exists <openerp> node and
+                 add list of xml files in self.msg_args
+        '''
+        xml_files = self.filter_files_ext('xml')
+        self.msg_args = []
+        for xml_file in xml_files:
+            doc = self.parse_xml(os.path.join(self.module_path, xml_file))
+            openerp_nodes = doc.xpath("/openerp") \
+                if not isinstance(doc, basestring) else []
+            if openerp_nodes:
+                lineno = openerp_nodes[0].sourceline
+                self.msg_args.append((
+                    xml_file, lineno))
+        if self.msg_args:
+            return False
+        return True
diff --git a/pylint_odoo/test/main.py b/pylint_odoo/test/main.py
@@ -8,7 +8,7 @@
 from pylint_odoo import misc
 
 
-EXPECTED_ERRORS = 47
+EXPECTED_ERRORS = 52
 
 
 class MainTest(unittest.TestCase):