-
-
Notifications
You must be signed in to change notification settings - Fork 322
[ADD][16.0] base_user_group_mgmt: manage groups/roles assignation with validation #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
sbejaoui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Code review
| @@ -0,0 +1,7 @@ | |||
| [ This file is optional and contains additional credits, other than | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unused README fragment
| <!-- <record--> | ||
| <!-- model="ir.actions.act_window"--> | ||
| <!-- id="base_security_update_request_request_line_act_window"--> | ||
| <!-- >--> | ||
| <!-- <field name="name">Base Security Update Line</field> <!– TODO –>--> | ||
| <!-- <field name="res_model">base.security.update.request.line</field>--> | ||
| <!-- <field name="view_mode">tree,form</field>--> | ||
| <!-- <field name="domain">[]</field>--> | ||
| <!-- <field name="context">{}</field>--> | ||
| <!-- </record>--> | ||
|
|
||
| <!-- <record model="ir.ui.menu" id="base_security_update_request_request_line_menu">--> | ||
| <!-- <field name="name">Base Security Update Line</field>--> | ||
| <!-- <field name="parent_id" ref="xmlid of parent menu" /> <!– TODO –>--> | ||
| <!-- <field--> | ||
| <!-- name="action"--> | ||
| <!-- ref="base_security_update_request_request_line_act_window"--> | ||
| <!-- />--> | ||
| <!-- <field name="sequence" eval="16" /> <!– TODO –>--> | ||
| <!-- </record>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <!-- <record--> | |
| <!-- model="ir.actions.act_window"--> | |
| <!-- id="base_security_update_request_request_line_act_window"--> | |
| <!-- >--> | |
| <!-- <field name="name">Base Security Update Line</field> <!– TODO –>--> | |
| <!-- <field name="res_model">base.security.update.request.line</field>--> | |
| <!-- <field name="view_mode">tree,form</field>--> | |
| <!-- <field name="domain">[]</field>--> | |
| <!-- <field name="context">{}</field>--> | |
| <!-- </record>--> | |
| <!-- <record model="ir.ui.menu" id="base_security_update_request_request_line_menu">--> | |
| <!-- <field name="name">Base Security Update Line</field>--> | |
| <!-- <field name="parent_id" ref="xmlid of parent menu" /> <!– TODO –>--> | |
| <!-- <field--> | |
| <!-- name="action"--> | |
| <!-- ref="base_security_update_request_request_line_act_window"--> | |
| <!-- />--> | |
| <!-- <field name="sequence" eval="16" /> <!– TODO –>--> | |
| <!-- </record>--> |
db14779 to
4954191
Compare
4954191 to
5bfe932
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
acsonefho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 💪
This PR creates two modules which allow users to assign group and roles to a user only if a workflow is approved.
Related fields are set readonly (only in the UI)